From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] scripts: add checkpatch wrapper Date: Fri, 23 Oct 2015 09:03:25 -0700 Message-ID: <20151023090325.3a83fa0c@xeon-e3> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id E806A5A1F for ; Fri, 23 Oct 2015 18:03:16 +0200 (CEST) Received: by pasz6 with SMTP id z6so121805356pas.2 for ; Fri, 23 Oct 2015 09:03:16 -0700 (PDT) In-Reply-To: <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 23 Oct 2015 17:53:25 +0200 Thomas Monjalon wrote: > + > +# override default Linux options > +options="$options --max-line-length=$length" > +options="$options --show-types" > +options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > +VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\ > +SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > +NEW_TYPEDEFS,COMPLEX_MACRO,COMPARISON_TO_NULL" Please keep some of these: PARENTHESIS_ALIGNMENT LINUX_VERSION_CODE COMPLEX_MACRO All of these are indications of problems in code.