From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Fri, 23 Oct 2015 12:46:56 +0300 Subject: [U-Boot] [PATCH 00/12] SPL mmc refactor and alternate boot device feature In-Reply-To: References: <1445515280-21389-1-git-send-email-nikita@compulab.co.il> Message-ID: <20151023094655.GB11008@skynet> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Otavio, On Thu, Oct 22, 2015 at 10:24:57AM -0200, Otavio Salvador wrote: > On Thu, Oct 22, 2015 at 10:01 AM, Nikita Kiryanov wrote: > > This series has two parts: patches 1-7 perform refactors aimed at reducing the > > ifdef complexity of SPL mmc code (and some nand as well). This refactor also > > addresses a few design issues I noticed while working on the refactor. > > > > The rest of the series introduces a new SPL feature that allows board code to > > define a list of boot devices that SPL will try before failing (instead of the > > only one device it attempts now). This feature is useful for implementing > > fallbacks, as well as reacting to bootROM sequences. For example: > > > > On CM-FX6, if boot from the alternate boot device (MMC) fails, the bootROM > > proceeds to try boot from SPI flash. If the SPI flash boot is succesful, SPL > > will still try to load U-Boot from MMC, instead of from the actual boot device > > (SPI flash), and probably fail and hang. The alternate boot feature makes it > > possible for SPL to follow the MMC boot attempt with boot from the SPI flash. > > The CM-FX6 based miniature PC Utilite depends on this capability for its SPI > > flash boot to work, since SPI flash boot is only attempted if MMC boot fails. > > > > This series was tested on CM-FX6 and compile tested for arm and powerpc. > > Thanks a lot for working on this; it does improves the SPL framework > and extends its feature set. One thing I missed is the patches to > rework the current boards removing the defines the serie drops and a > proper documentation in the README files. I'll make the additions once it's clear what part of the spl_mmc refactor is accepted. There shouldn't be much changes for the board files though, since the #defines themselves are not eliminated, just that their checks are moved to a place where they will not make it difficult to read the source code. > > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.br http://code.ossystems.com.br > Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 >