From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: MUSB peripheral DMA regression caused by driver core runtime PM change Date: Fri, 23 Oct 2015 13:36:21 -0700 Message-ID: <20151023203620.GY3078@atomide.com> References: <20151023192044.GX3078@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:42804 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbbJWUgY (ORCPT ); Fri, 23 Oct 2015 16:36:24 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Alan Stern Cc: Grygorii Strashko , Felipe Balbi , gregkh@linuxfoundation.org, linux-omap@vger.kernel.org, "Rafael J. Wysocki" , Bin Liu , Heikki Krogerus , Andy Shevchenko , Lee Jones , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux PM list * Alan Stern [151023 13:34]: > On Fri, 23 Oct 2015, Tony Lindgren wrote: > > > > Thus the sequence of events should be: > > > > > > Allocate the musb device; > > > Runtime-enable the omap2430 (since it is now safe to do so); > > > Runtime-enable the musb and declare it irq_safe (this will > > > automatically runtime-resume the omap2430); > > > Register the musb. > > > > > > If things are done this way, no special action needs to be taken. > > > > Yes good point, that requires changing the init for the whole > > drivers/musb though. > > This will have to be done anyway, since the way it is now (if I > understand correctly), the musb is registered and made available to > userspace before its parent is operational (i.e., at full power). Yes I agree. > > Also, we should reorganize the whole musb and make > > the platform glue and musb core drivers completely separate using a > > shared interrupt where needed. > > > > For the regression for the -rc series? Do you see any better > > alternatives to what I posted? > > No. OK thanks, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 23 Oct 2015 13:36:21 -0700 Subject: MUSB peripheral DMA regression caused by driver core runtime PM change In-Reply-To: References: <20151023192044.GX3078@atomide.com> Message-ID: <20151023203620.GY3078@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Alan Stern [151023 13:34]: > On Fri, 23 Oct 2015, Tony Lindgren wrote: > > > > Thus the sequence of events should be: > > > > > > Allocate the musb device; > > > Runtime-enable the omap2430 (since it is now safe to do so); > > > Runtime-enable the musb and declare it irq_safe (this will > > > automatically runtime-resume the omap2430); > > > Register the musb. > > > > > > If things are done this way, no special action needs to be taken. > > > > Yes good point, that requires changing the init for the whole > > drivers/musb though. > > This will have to be done anyway, since the way it is now (if I > understand correctly), the musb is registered and made available to > userspace before its parent is operational (i.e., at full power). Yes I agree. > > Also, we should reorganize the whole musb and make > > the platform glue and musb core drivers completely separate using a > > shared interrupt where needed. > > > > For the regression for the -rc series? Do you see any better > > alternatives to what I posted? > > No. OK thanks, Tony