From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH net-next 7/8] xen-netback: add support for a multi-queue hash mapping table Date: Mon, 26 Oct 2015 17:05:51 +0000 Message-ID: <20151026170551.GG18674__39053.8899148398$1445879218$gmane$org@zion.uk.xensource.com> References: <1445423785-4654-1-git-send-email-paul.durrant@citrix.com> <1445423785-4654-8-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZqlDX-0004BF-G8 for xen-devel@lists.xenproject.org; Mon, 26 Oct 2015 17:05:55 +0000 Content-Disposition: inline In-Reply-To: <1445423785-4654-8-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: netdev@vger.kernel.org, Wei Liu , Ian Campbell , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, Oct 21, 2015 at 11:36:24AM +0100, Paul Durrant wrote: > Advertise the capability to handle a hash mapping specified by the > frontend (see netif.h for details). > > Add an ndo_select() entry point so that, of the frontend does specify a "if the frontend ..." > hash mapping, the skb hash is extracted and mapped to a queue. If no > mapping is specified then the fallback queue selection function is > called so there is no change in behaviour. > > Signed-off-by: Paul Durrant [...] > +static void xen_hash_mapping_changed(struct xenbus_watch *watch, > + const char **vec, unsigned int len) > +{ > + struct xenvif *vif = container_of(watch, struct xenvif, > + hash_mapping_watch); > + > + xen_net_read_multi_queue_hash_mapping(vif); Is it safe / correct to not stop the vif before changing mapping table? Wei.