From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932464AbbJ0ONn (ORCPT ); Tue, 27 Oct 2015 10:13:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:53118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932301AbbJ0ONl (ORCPT ); Tue, 27 Oct 2015 10:13:41 -0400 Date: Tue, 27 Oct 2015 11:13:35 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , "Liang, Kan" Subject: Re: [PATCH 11/52] perf tools: Add stat config event Message-ID: <20151027141335.GC9405@kernel.org> References: <1445784728-21732-1-git-send-email-jolsa@kernel.org> <1445784728-21732-12-git-send-email-jolsa@kernel.org> <20151027131605.GA9405@kernel.org> <20151027133043.GA21158@krava.brq.redhat.com> <20151027134440.GB9405@kernel.org> <20151027135154.GA21699@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151027135154.GA21699@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 27, 2015 at 02:51:54PM +0100, Jiri Olsa escreveu: > On Tue, Oct 27, 2015 at 10:44:40AM -0300, Arnaldo Carvalho de Melo wrote: > > > I think we could easily add record specific event for this > > > once it's needed.. there's plenty of free numbers in user > > > events area ;-) > > Shhh, don't ask PeterZ about it ;-) > > But seriously, what makes this specific? Do you envision the stat code > > needing 2^64-1 tags? > nope ;-) > it's just the read function perf_event__read_stat_config takes the > 'struct perf_stat_config *' and updates it based on the event data. > we would need to change the code to be more generic.. but as you said, > it's future ;-) Right, I applied the patch, I was just curious if I was missing some detail that would prevent us from using this as a generic tag/value perf.data storing facility. - Arnaldo