From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755532AbbJ1HBC (ORCPT ); Wed, 28 Oct 2015 03:01:02 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:35101 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755516AbbJ1HA6 (ORCPT ); Wed, 28 Oct 2015 03:00:58 -0400 Date: Wed, 28 Oct 2015 16:00:45 +0900 From: Darren Hart To: Olof Johansson Cc: Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, dvhart@linux.intel.com Subject: Re: [PATCH 07/10] merge_config.sh: add tests Message-ID: <20151028070045.GI1854@malice.jf.intel.com> References: <1445992931-28107-1-git-send-email-olof@lixom.net> <1445992931-28107-8-git-send-email-olof@lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445992931-28107-8-git-send-email-olof@lixom.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 09:42:08AM +0900, Olof Johansson wrote: > For being a small script, merge_config.sh is fairly scary to change since there's no > real way to know if you did something wrong. So it seems appropriate to add a simple > test suite. > > I've started with testcases in the areas I care about, other should of course feel > free to expand on this. > > Use is simple, from the kernel tree, run ./scripts/kconfig/merge_config_test/runall. > It'll execute out of a tmpdir under /tmp. > > Signed-off-by: Olof Johansson Thanks for writing the test cases. Shell scripting is so easy to bikeshed - so I'm going to skip that. I didn't catch any bashisms, and the test coverage is good. Reviewed-by: Darren Hart -- Darren Hart Intel Open Source Technology Center