From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755572AbbJ1HL0 (ORCPT ); Wed, 28 Oct 2015 03:11:26 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38921 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754827AbbJ1HLZ (ORCPT ); Wed, 28 Oct 2015 03:11:25 -0400 Date: Wed, 28 Oct 2015 16:11:19 +0900 From: Darren Hart To: Olof Johansson Cc: Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, dvhart@linux.intel.com Subject: Re: [PATCH 08/10] merge_config.sh: use trap for cleanup Message-ID: <20151028071119.GK1854@malice.jf.intel.com> References: <1445992931-28107-1-git-send-email-olof@lixom.net> <1445992931-28107-9-git-send-email-olof@lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445992931-28107-9-git-send-email-olof@lixom.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 09:42:09AM +0900, Olof Johansson wrote: > Use the trap to cleanup even on regular exit. > > Signed-off-by: Olof Johansson > --- > scripts/kconfig/merge_config.sh | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh > index 1945b2c..b26c0ef 100755 > --- a/scripts/kconfig/merge_config.sh > +++ b/scripts/kconfig/merge_config.sh > @@ -23,10 +23,12 @@ > EXITVAL=0 > > clean_up() { > - rm -f $TMP_FILE > + if [ -n "$CLEAN_FILES" ] ; then > + rm -f $CLEAN_FILES Hrm... where did CLEAN_FILES come from? I dodn't see it in master and I don't see it in patches 1-7. Did I miss it? -- Darren Hart Intel Open Source Technology Center