From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrik Jakobsson Subject: Re: [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized Date: Wed, 28 Oct 2015 16:52:01 +0100 Message-ID: <20151028155201.GA4506@patrik-desktop.isw.intel.com> References: <1445593310-26596-1-git-send-email-patrik.jakobsson@linux.intel.com> <1445971291.2408.68.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 431156E2B7 for ; Wed, 28 Oct 2015 08:52:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1445971291.2408.68.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjcsIDIwMTUgYXQgMDg6NDE6MzFQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE9uIHBlLCAyMDE1LTEwLTIzIGF0IDExOjQxICswMjAwLCBQYXRyaWsgSmFrb2Jzc29uIHdy b3RlOgo+ID4gVGhlIGN1cnJlbnQgQ1NSIGxvYWRpbmcgY29kZSBkZXBlbmRzIG9uIHRoZSBDU1Ig cHJvZ3JhbSBtZW1vcnkgdG8gYmUKPiA+IGNsZWFyZWQgYWZ0ZXIgYm9vdC4gVGhpcyBpcyB1bmZv cnR1bmF0ZWx5IG5vdCB0cnVlIG9uIGFsbCBoYXJkd2FyZS4KPiA+IEluc3RlYWQgbWFrZSB1c2Ug b2YgdGhlIEZXX1VOSU5JVElBTElaRUQgc3RhdGUgaW4gaW5pdCBhbmQgY2hlY2sgZm9yCj4gPiBG V19MT0FERUQgdG8gcHJldmVudCBpbml0IHBhdGggZnJvbSBza2lwcGluZyB0aGUgYWN0dWFsIHBy b2dyYW1taW5nLgo+ID4gCj4gPiB2MjogTW92ZSBpbml0aWFsaXphdGlvbiBvZiBzdGF0ZSB0byBh ZnRlciBIQVNfQ1NSKCkgY2hlY2sKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUGF0cmlrIEpha29i c3NvbiA8cGF0cmlrLmpha29ic3NvbkBsaW51eC5pbnRlbC5jb20+Cj4gPiBUZXN0ZWQtYnk6IFJv ZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBSb2Ry aWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jc3IuYyB8IDQgKysrLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Nzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3Ny LmMKPiA+IGluZGV4IDllNTMwYTcuLmU3NGMwOWUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY3NyLmMKPiA+IEBAIC0yNzEsNyArMjcxLDcgQEAgdm9pZCBpbnRlbF9jc3JfbG9hZF9wcm9n cmFtKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgCSAqIFVuZm9ydHVuYXRlbHkgdGhlIEFD UEkgc3Vic3lzdGVtIGRvZXNuJ3QgeWV0IGdpdmUgdXMgYSB3YXkgdG8KPiA+ICAJICogZGlmZmVy ZW50aWF0ZSB0aGlzLCBoZW5jZSBmaWd1cmUgaXQgb3V0IHdpdGggdGhpcyBoYWNrLgo+ID4gIAkg Ki8KPiA+IC0JaWYgKEk5MTVfUkVBRChDU1JfUFJPR1JBTSgwKSkpCj4gPiArCWlmIChJOTE1X1JF QUQoQ1NSX1BST0dSQU0oMCkpICYmIGRldl9wcml2LT5jc3Iuc3RhdGUgPT0gRldfTE9BREVEKQo+ ID4gIAkJcmV0dXJuOwo+IAo+IEFzIEFuaW1lc2ggc2FpZCBjc3ItPnN0YXRlIGlzIGJlaW5nIHJl bW92ZWQsIHNvIEknZCBwcmVmZXIgaWYgd2UgZGlkbid0Cj4gYWRkIG5ldyB1c2VycyBmb3IgaXQu Cj4gCj4gSSB0aGluayB0aGUgcHJvcGVyIHNvbHV0aW9uIGZvciB0aGlzIHdvdWxkIGJlIHRvIHJl cHJvZ3JhbSB0aGUgZmlybXdhcmUKPiBvbmx5IHdoZW4gd2Uga25vdyB3ZSBoYXZlIHRvIGFuZCBu b3QgaGF2ZSBoZXJlIGVpdGhlciBvZiB0aGUgYWJvdmUKPiBjaGVja3MuIFRoZSBwb2ludHMgd2Ug bmVlZCB0byByZXByb2dyYW0gdGhlIGZpcm13YXJlOgo+IAo+IFMzL1M0IGJvdGggb24gU0tMLgo+ IFMzL1M0L0RDOSAocnVudGltZSBzdXNwZW5kKSBvbiBCWFQuCgpJc24ndCB0aGlzIHdoYXQgY3Ny LT5zdGF0ZSB3YXMgaW50ZW5kZWQgdG8gc29sdmUgaW4gdGhlIGZpcnN0IHBsYWNlPyBJdCdzIHZl cnkKZWFzeSB0byBnZXQgbG9zdCBpbiB0aGUgZGlzY3Vzc2lvbnMgYXJvdW5kIERNQyBzbyBJJ3Zl IG1pZ2h0IGhhdmUgbWlzc2VkCnNvbWV0aGluZy4KCj4gCj4gVG8gZml4IHRoaXMgcGFydGljdWxh ciBidWcgeW91IGNvdWxkIGFsc28ganVzdCBhZGQgYW4KPiBpbnRlbF9jc3JfcmVwcm9ncmFtKCkg dGhhdCB3b3VsZCBjaGVjayBmb3IgQ1NSX1BST0dSQU0oMCkgYXMgbm93LCB3aGlsZQo+IGR1cmlu ZyBkcml2ZXIgbG9hZGluZyB5b3Ugd291bGQgcHJvZ3JhbSB0aGUgZmlybXdhcmUgdW5jb25kaXRp b25hbGx5LgoKRGlkIHNvbWUgbW9yZSBkaWdnaW5nIGFuZCBpdCBzZWVtcyB0aGUgQ1NSIHByb2dy YW0gaXMgbm90IGNsZWFyZWQgb24gd2FybSBib290LgpTbyBjaGVja2luZyBDU1JfUFJPR1JBTSgw KSA9PSBwYXlsb2FkWzBdIHdpbGwgbm90IHdvcmsuIERvbid0IHRoaW5rIHdlIGNhbgpmaWd1cmUg b3V0IHRoZSBDU1Igc3RhdHVzIGJ5IHByb2JpbmcgaGFyZHdhcmUgc28gd2UgbXVzdCBrZWVwIGEg ZmxhZyBmb3IgdGhpcwpzb21ld2hlcmUuIFRoZSBDU1IgcHJvZ3JhbSBsb2FkaW5nIGlzIGFzeW5j IHNvIHRoZSBzdGF0ZSBuZWVkIHRvIGJlIHN0b3JlZApzb21ld2hlcmUgYW5kIG5vdCBqdXN0IHBh c3NlZCBhbG9uZyBhcyBhIGZ1bmN0aW9uIGFyZ3VtZW50LgoKLVBhdHJpawoKPiAKPiAtLUltcmUK PiAKPiAKPiA+ICAKPiA+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmNzcl9sb2NrKTsKPiA+IEBA IC00MjgsNiArNDI4LDggQEAgdm9pZCBpbnRlbF9jc3JfdWNvZGVfaW5pdChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KQo+ID4gIAlpZiAoIUhBU19DU1IoZGV2KSkKPiA+ICAJCXJldHVybjsKPiA+ICAK PiA+ICsJaW50ZWxfY3NyX2xvYWRfc3RhdHVzX3NldChkZXZfcHJpdiwgRldfVU5JTklUSUFMSVpF RCk7Cj4gPiArCj4gPiAgCWlmIChJU19TS1lMQUtFKGRldikpCj4gPiAgCQljc3ItPmZ3X3BhdGgg PSBJOTE1X0NTUl9TS0w7Cj4gPiAgCWVsc2UgaWYgKElTX0JST1hUT04oZGV2X3ByaXYpKQo+IAo+ IAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=