From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZroVc-0001fH-2E for mharc-grub-devel@gnu.org; Thu, 29 Oct 2015 10:48:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZroVY-0001eh-Hl for grub-devel@gnu.org; Thu, 29 Oct 2015 10:48:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZroVU-0005mW-7z for grub-devel@gnu.org; Thu, 29 Oct 2015 10:48:52 -0400 Received: from boksu.net-space.pl ([185.15.1.105]:54171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZroVT-0005m8-Sm for grub-devel@gnu.org; Thu, 29 Oct 2015 10:48:48 -0400 Received: (from localhost user: 'dkiper' uid#4000 fake: STDIN (dkiper@boksu.net-space.pl)) by router-fw-old.local.net-space.pl id S1323757AbbJ2Osq (ORCPT ); Thu, 29 Oct 2015 15:48:46 +0100 Date: Thu, 29 Oct 2015 15:48:46 +0100 From: Daniel Kiper To: The development of GNU GRUB Subject: Re: [PATCH 1/3] ieee1275: ofdisk dangling pointer Message-ID: <20151029144846.GA8476@router-fw-old.local.net-space.pl> References: <1671671c705298f7d6e8c7e79805564b3b662548.1445895272.git.eric.snowberg@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1671671c705298f7d6e8c7e79805564b3b662548.1445895272.git.eric.snowberg@oracle.com> User-Agent: Mutt/1.3.28i X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.15.1.105 Cc: john.haxby@oracle.com, jose.marchesi@oracle.com, karl.volz@oracle.com, allen.pais@oracle.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 14:48:54 -0000 On Mon, Oct 26, 2015 at 05:43:36PM -0400, Eric Snowberg wrote: > Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - > "Don't continue to query block-size if disk doesn't have it.??? > a dangling pointer was introduced. > > Fix dangling pointer issue in grub_ofdisk_open where devpath is freed > and then used again within the call to grub_ofdisk_get_block_size. This > solves many memory corruption issues we were seeing. > > Signed-off-by: Eric Snowberg Please CC me too if you repost patches on grub-devel. Daniel