From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id B25E67CBF for ; Thu, 29 Oct 2015 18:39:35 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 9438230404E for ; Thu, 29 Oct 2015 16:39:35 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id EtrcaXFowJ2Eurb1 for ; Thu, 29 Oct 2015 16:39:33 -0700 (PDT) Date: Fri, 30 Oct 2015 10:39:11 +1100 From: Dave Chinner Subject: Re: [PATCH 4/6] xfs: DAX does not use IO completion callbacks Message-ID: <20151029233911.GT19199@dastard> References: <1445225238-30413-1-git-send-email-david@fromorbit.com> <1445225238-30413-5-git-send-email-david@fromorbit.com> <20151029142957.GF11663@bfoster.bfoster> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151029142957.GF11663@bfoster.bfoster> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: ross.zwisler@linux.intel.com, jack@suse.cz, xfs@oss.sgi.com On Thu, Oct 29, 2015 at 10:29:57AM -0400, Brian Foster wrote: > On Mon, Oct 19, 2015 at 02:27:16PM +1100, Dave Chinner wrote: > > From: Dave Chinner > > > > For DAX, we are now doing block zeroing and > > we are updating the file size during allocation. This means we no > > longer need an IO completion callback to do these things, so remove > > the completion callbacks from the __dax_fault and __dax_mkwrite > > calls. > > > > Where do we "update the file size during allocation?" Stale comment. For page faults, we'll never update the file size (segv if fault is beyond EOF), and DIO still does IO completion based file size updates. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs