From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v6 2/4] drm/i915: Fix double unref in intelfb_alloc failure path Date: Fri, 30 Oct 2015 19:17:07 +0100 Message-ID: <20151030181707.GP16848@phenom.ffwll.local> References: <20151015173423.GK26517@intel.com> <760b19948cb31e3a219124a34c4db2bf95e9086b.1445771693.git.lukas@wunner.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id A36B86EC76 for ; Fri, 30 Oct 2015 11:17:11 -0700 (PDT) Received: by wmeg8 with SMTP id g8so18098311wme.1 for ; Fri, 30 Oct 2015 11:17:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <760b19948cb31e3a219124a34c4db2bf95e9086b.1445771693.git.lukas@wunner.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lukas Wunner Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMjIsIDIwMTUgYXQgMDE6Mzc6MThQTSArMDIwMCwgTHVrYXMgV3VubmVyIHdy b3RlOgo+IEluIGludGVsZmJfYWxsb2MoKSwgaWYgdGhlIGNhbGwgdG8gaW50ZWxfcGluX2FuZF9m ZW5jZV9mYl9vYmooKSBmYWlscywKPiB0aGUgYm8gaXMgdW5yZWZlZCB0d2ljZTogQnkgZHJtX2Zy YW1lYnVmZmVyX3JlbW92ZSgpIGFuZCBvbmNlIG1vcmUgYnkKPiBkcm1fZ2VtX29iamVjdF91bnJl ZmVyZW5jZSgpLiBGaXggaXQuCj4gCj4gUmVwb3J0ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTHVrYXMgV3VubmVy IDxsdWthc0B3dW5uZXIuZGU+CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2 LmMgfCA1ICsrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2 LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gaW5kZXggNGZkNWZkZi4u ZWM4MmI1MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+IEBAIC0xNTYsOCAr MTU2LDkgQEAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0cnVjdCBkcm1fZmJfaGVscGVyICpo ZWxwZXIsCj4gIAo+ICAJZmIgPSBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZShkZXYsICZtb2Rl X2NtZCwgb2JqKTsKPiAgCWlmIChJU19FUlIoZmIpKSB7Cj4gKwkJZHJtX2dlbV9vYmplY3RfdW5y ZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4gIAkJcmV0ID0gUFRSX0VSUihmYik7Cj4gLQkJZ290byBv dXRfdW5yZWY7Cj4gKwkJZ290byBvdXQ7Cj4gIAl9Cj4gIAo+ICAJLyogRmx1c2ggZXZlcnl0aGlu ZyBvdXQsIHdlJ2xsIGJlIGRvaW5nIEdUVCBvbmx5IGZyb20gbm93IG9uICovCj4gQEAgLTE3Myw4 ICsxNzQsNiBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIg KmhlbHBlciwKPiAgCj4gIG91dF9mYjoKPiAgCWRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUoZmIpOwo+ IC1vdXRfdW5yZWY6Cj4gLQlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsK PiAgb3V0Ogo+ICAJcmV0dXJuIHJldDsKPiAgfQo+IC0tIAo+IDEuOC41LjIgKEFwcGxlIEdpdC00 OCkKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==