From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v6 4/4] drm/i915: Fix error handling in intelfb_create Date: Fri, 30 Oct 2015 19:23:05 +0100 Message-ID: <20151030182305.GQ16848@phenom.ffwll.local> References: <20151015173423.GK26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EF676E08B for ; Fri, 30 Oct 2015 11:23:09 -0700 (PDT) Received: by wmll128 with SMTP id l128so18702905wml.0 for ; Fri, 30 Oct 2015 11:23:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lukas Wunner Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBPY3QgMjQsIDIwMTUgYXQgMTI6Mjc6NTdBTSArMDIwMCwgTHVrYXMgV3VubmVyIHdy b3RlOgo+IGludGVsZmJfY3JlYXRlKCkgaXMgY2FsbGVkIG9uY2Ugb24gZHJpdmVyIGluaXRpYWxp emF0aW9uLiBJdCBlaXRoZXIKPiB1c2VzIHRoZSBmYiBpbmhlcml0ZWQgZnJvbSBCSU9TIG9yIGFs bG9jYXRlcyBhIG5ldyBvbmUgYnkgY2FsbGluZwo+IGludGVsZmJfYWxsb2MoKS4gQWZ0ZXJ3YXJk cywgaXQgY2FsbHMgdHdvIGZ1bmN0aW9ucyB3aGljaCBjYW4gZmFpbDoKPiAKPiAtIGRybV9mYl9o ZWxwZXJfYWxsb2NfZmJpKCkgY2FuIGZhaWwgd2l0aCAtRU5PTUVNLgo+IC0gaW9yZW1hcF93Yygp IGNhbiBmYWlsIG9uIGFsaWdubWVudCBpc3N1ZXMgZXRjLgo+IAo+IEluIHRoZSBjYXNlIHdoZXJl IHdlIGFsbG9jYXRlZCB0aGUgZmIgd2l0aCBpbnRlbGZiX2FsbG9jKCksIGlmIGVpdGhlcgo+IG9m IHRoZSB0d28gZnVuY3Rpb25zIGZhaWwgd2UgY3VycmVudGx5IHVucGluIGFuZCB1bnJlZiB0aGUg Ym8sCj4gYnV0IGxlYWsgdGhlIGZiLiBXZSBuZWVkIHRvIHVucmVmIHRoZSBmYiBpbnN0ZWFkIG9m IHRoZSBibyBoZXJlLgo+IAo+IEluIHRoZSBjYXNlIHdoZXJlIHRoZSBmYiB3YXMgaW5oZXJpdGVk IGZyb20gQklPUywgdGhlIGZiIHN0cnVjdCB3YXMKPiBhbGxvY2F0ZWQgYnkgZGV2X3ByaXYtPmRp c3BsYXkuZ2V0X2luaXRpYWxfcGxhbmVfY29uZmlnKCkgYW5kIGlzIGluCj4gYWN0aXZlIHVzZSBi eSBhIGNydGMsIHNvIGl0IHNlZW1zIHdyb25nIHRvIHVucGluIGFuZCB1bnJlZiBpdHMgYm8uCj4g V2UgY291bGQgdHJlYXQgZmFpbHVyZSBvZiB0aGUgYWJvdmUgdHdvIGZ1bmN0aW9ucyBhcyBhIGZh dGFsIGVycm9yCj4gYW5kIGNhbGwgaTkxNV9kcml2ZXJfdW5sb2FkKCksIG9yIHRyeSB0byBsaW1w IG9uIChmYmNvbiB3b24ndCB3b3JrLAo+IGJ1dCBYMTEgbWlnaHQpLiBMZXQncyBkbyB0aGUgbGF0 dGVyLgo+IAo+IEhvd2V2ZXIgd2Ugc2hvdWxkIGF0IGxlYXN0IGxvZyBhbiBlcnJvciBtZXNzYWdl LiBDdXJyZW50bHkgYSBmYWlsdXJlCj4gb2YgdGhlIGFib3ZlIHR3byBmdW5jdGlvbnMgaXMgbm90 IHJlcG9ydGVkIGF0IGFsbDogVGhlIG5lZ2F0aXZlIHJldHVybgo+IHZhbHVlIGlzIHBhc3NlZCB1 cCB0aGUgY2FsbCBzdGFjayB0byBpbnRlbF9mYmRldl9pbml0aWFsX2NvbmZpZygpCj4gd2hpY2gg aWdub3JlcyBpdC4KPiAKPiBUbyBiZSBmYWlyLCB0aGlzIGlzIGEgY29ybmVyIGNhc2Ugd2hpY2gg ZmV3IHVzZXJzIHByb2JhYmx5IGV2ZXIKPiBleHBlcmllbmNlLCBuZXZlcnRoZWxlc3Mgd2Ugc2hv dWxkIHRyeSB0byBnZXQgaXQgcmlnaHQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTHVrYXMgV3VubmVy IDxsdWthc0B3dW5uZXIuZGU+CgpJIGRvbid0IHRoaW5rIHRoZXJlJ3MgYSBsZWFrIGhlcmUgcmVh bGx5LiBXZSBhbHdheXMgYXNzaWduIGlmYmRldi0+ZmIgaW4KaW50ZWxmYl9hbGxvYywgd2hpY2gg bWVhbnMgdGhlIGZiZGV2IHRlYXJkb3duIGNvZGUgd2lsbCB0YWtlIGNhcmUgb2YgaXQuClRoZSBj b3JyZWN0IGFwcHJvYWNoIGlzIHByb2JhYmx5IHRvIG5vdCB1bnJlZiBhbnl0aGluZyBhdCBhbGws IG9yIGlmIHdlCnVucmVmIHRoZW4gd2UgaGF2ZSB0byBjbGVhciBpZmJkZXYtPmZiIChzaW5jZSBp dCdzIHRoZSByZWZlcmVuY2UgdGhhdCB2ZXJ5CnBvaW50ZXIgaXMgaG9sZGluZyB0aGF0IHdlJ3Jl IGNsZWFyaW5nIHVwKS4KLURhbmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZmJkZXYuYyB8IDEzICsrKysrKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2ZiZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5j Cj4gaW5kZXggMTI1OTdiNS4uYjhjMTFhMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9mYmRldi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJk ZXYuYwo+IEBAIC0yMjcsNiArMjI3LDcgQEAgc3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1 Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAKPiAgCWluZm8gPSBkcm1fZmJfaGVscGVyX2Fs bG9jX2ZiaShoZWxwZXIpOwo+ICAJaWYgKElTX0VSUihpbmZvKSkgewo+ICsJCURSTV9FUlJPUigi RmFpbGVkIHRvIGFsbG9jYXRlIGZiX2luZm9cbiIpOwo+ICAJCXJldCA9IFBUUl9FUlIoaW5mbyk7 Cj4gIAkJZ290byBvdXRfdW5waW47Cj4gIAl9Cj4gQEAgLTI1Myw2ICsyNTQsNyBAQCBzdGF0aWMg aW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAkJaW9y ZW1hcF93YyhkZXZfcHJpdi0+Z3R0Lm1hcHBhYmxlX2Jhc2UgKyBpOTE1X2dlbV9vYmpfZ2d0dF9v ZmZzZXQob2JqKSwKPiAgCQkJICAgc2l6ZSk7Cj4gIAlpZiAoIWluZm8tPnNjcmVlbl9iYXNlKSB7 Cj4gKwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcmVtYXAgZnJhbWVidWZmZXIgaW50byB2aXJ0dWFs IG1lbW9yeVxuIik7Cj4gIAkJcmV0ID0gLUVOT1NQQzsKPiAgCQlnb3RvIG91dF9kZXN0cm95X2Zi aTsKPiAgCX0KPiBAQCAtMjg0LDkgKzI4NiwxNCBAQCBzdGF0aWMgaW50IGludGVsZmJfY3JlYXRl KHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIG91dF9kZXN0cm95X2ZiaToKPiAgCWRy bV9mYl9oZWxwZXJfcmVsZWFzZV9mYmkoaGVscGVyKTsKPiAgb3V0X3VucGluOgo+IC0JaTkxNV9n ZW1fb2JqZWN0X2dndHRfdW5waW4ob2JqKTsKPiAtCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNl KCZvYmotPmJhc2UpOwo+IC0JbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwkv KiBJZiBmYiB3YXMgcHJlYWxsb2NhdGVkIGJ5IEJJT1MsIHRyeSB0byBsaW1wIG9uLiBFbHNlIGZy ZWUgaXQuICovCj4gKwlpZiAocHJlYWxsb2MpCj4gKwkJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVj dF9tdXRleCk7Cj4gKwllbHNlIHsKPiArCQlpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmop Owo+ICsJCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJCWRybV9mcmFtZWJ1 ZmZlcl91bnJlZmVyZW5jZSgmaW50ZWxfZmItPmJhc2UpOwo+ICsJfQo+ICAJcmV0dXJuIHJldDsK PiAgfQo+ICAKPiAtLSAKPiAxLjguNS4yIChBcHBsZSBHaXQtNDgpCj4gCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVy ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=