From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbbKBTd3 (ORCPT ); Mon, 2 Nov 2015 14:33:29 -0500 Received: from smtprelay0180.hostedemail.com ([216.40.44.180]:42594 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751836AbbKBTd1 (ORCPT ); Mon, 2 Nov 2015 14:33:27 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2895:3138:3139:3140:3141:3142:3353:3622:3865:3866:3868:3870:3871:3872:4419:4605:5007:6261:6742:7875:10004:10400:10848:10967:11026:11232:11658:11914:12517:12519:12555:12740:13069:13311:13357:14096:14097:21080:30012:30054:30064:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:7,LUA_SUMMARY:none X-HE-Tag: pear53_752c88bd2d11d X-Filterd-Recvd-Size: 2794 Date: Mon, 2 Nov 2015 14:33:24 -0500 From: Steven Rostedt To: libin Cc: Sergei Shtylyov , , , , , , , , , , Subject: Re: [PATCH 1/3] recordmcount: fix endianness handling bug for nop_mcount Message-ID: <20151102143324.071eee7e@gandalf.local.home> In-Reply-To: <5634226A.9060208@huawei.com> References: <1446193864-24593-1-git-send-email-huawei.libin@huawei.com> <1446193864-24593-2-git-send-email-huawei.libin@huawei.com> <56338025.3060602@cogentembedded.com> <5634226A.9060208@huawei.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 31 Oct 2015 10:07:38 +0800 libin wrote: > > > on 2015/10/30 22:35, Sergei Shtylyov wrote: > > Hello. > > > > On 10/30/2015 11:31 AM, Li Bin wrote: > > > >> In nop_mcount, shdr->sh_offset and welp->r_offset should handle > >> endianness properly, otherwise it will trigger Segmentation fault > >> if the recordmcount main and file.o have different endianness. > >> > >> Cc: # 3.0+ > >> Signed-off-by: Li Bin > >> --- > >> scripts/recordmcount.h | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h > >> index 49b582a..dda9dba 100644 > >> --- a/scripts/recordmcount.h > >> +++ b/scripts/recordmcount.h > >> @@ -376,8 +376,9 @@ static void nop_mcount(Elf_Shdr const *const relhdr, > >> mcountsym = get_mcountsym(sym0, relp, str0); > >> > >> if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) { > >> - if (make_nop) > >> - ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset); > >> + if (make_nop) { > >> + ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset)); > >> + } > > > > {} not needed here. > > Oh, yes. When I cleaned the debugging code, forgot delete the {}. > > Is there a new version of this patch, or should I just take this and remove the '{}' myself? I already added the x86 update. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Mon, 2 Nov 2015 14:33:24 -0500 Subject: [PATCH 1/3] recordmcount: fix endianness handling bug for nop_mcount In-Reply-To: <5634226A.9060208@huawei.com> References: <1446193864-24593-1-git-send-email-huawei.libin@huawei.com> <1446193864-24593-2-git-send-email-huawei.libin@huawei.com> <56338025.3060602@cogentembedded.com> <5634226A.9060208@huawei.com> Message-ID: <20151102143324.071eee7e@gandalf.local.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 31 Oct 2015 10:07:38 +0800 libin wrote: > > > on 2015/10/30 22:35, Sergei Shtylyov wrote: > > Hello. > > > > On 10/30/2015 11:31 AM, Li Bin wrote: > > > >> In nop_mcount, shdr->sh_offset and welp->r_offset should handle > >> endianness properly, otherwise it will trigger Segmentation fault > >> if the recordmcount main and file.o have different endianness. > >> > >> Cc: # 3.0+ > >> Signed-off-by: Li Bin > >> --- > >> scripts/recordmcount.h | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h > >> index 49b582a..dda9dba 100644 > >> --- a/scripts/recordmcount.h > >> +++ b/scripts/recordmcount.h > >> @@ -376,8 +376,9 @@ static void nop_mcount(Elf_Shdr const *const relhdr, > >> mcountsym = get_mcountsym(sym0, relp, str0); > >> > >> if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) { > >> - if (make_nop) > >> - ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset); > >> + if (make_nop) { > >> + ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset)); > >> + } > > > > {} not needed here. > > Oh, yes. When I cleaned the debugging code, forgot delete the {}. > > Is there a new version of this patch, or should I just take this and remove the '{}' myself? I already added the x86 update. -- Steve