From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754193AbbKBV3v (ORCPT ); Mon, 2 Nov 2015 16:29:51 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:47650 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722AbbKBV3l (ORCPT ); Mon, 2 Nov 2015 16:29:41 -0500 Date: Mon, 2 Nov 2015 22:29:33 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Niklas Cassel Cc: Guenter Roeck , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash Message-ID: <20151102212933.GB4931@pengutronix.de> References: <1446431576-4385-1-git-send-email-linux@roeck-us.net> <20151102073755.GN4931@pengutronix.de> <5637D1F5.2090608@flawful.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5637D1F5.2090608@flawful.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Helo Niklas, On Mon, Nov 02, 2015 at 10:13:25PM +0100, Niklas Cassel wrote: > On 11/02/2015 08:37 AM, Uwe Kleine-König wrote: > >> The function call in the etraxfs-uart driver was not renamed, > >> possibly due to interference with commit 7b9c5162c182 ("serial: > >> etraxfs-uart: use mctrl_gpio helpers for handling modem signals"). > > Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling > > is missing. > > The only drivers including serial_mctrl_gpio.h is atmel_serial.c, > clps711x.c, mxs-auart.c and etraxfs-uart.c > > etraxfs commit > 7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handling modem signals") > is heavily influenced by > 62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling modem signals") > > a driver which also appears to lack mctrl irq setup/handling. > > > Uwe, are you going to convert all serial drivers that includes serial_mctrl_gpio.h to > use the new mctrl_gpio_init? (which also sets up irqs) That is the plan. For drivers like mxs-auart (that do irq handling) this is just simplification. When the irq handling is missing converting to the new mctrl_gpio_init might introduce regressions because it does request_irq which might fail. > Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_init handles if > they are missing. So even if etraxfs-uart.c currently lacks mctrl irq setup/handling, > if we migrate it to use the new mctrl_gpio_init, we will get this automatically? Right, if there are no gpios specified (new and old) mctrl_gpio is a nop. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |