From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754074AbbKCBNc (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Nov 2015 20:13:32 -0500
Received: from mail.kernel.org ([198.145.29.136]:44932 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751017AbbKCBN3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Nov 2015 20:13:29 -0500
Date: Mon, 2 Nov 2015 22:13:24 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
        Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Wang Nan <wangnan0@huawei.com>, Steven Rostedt <rostedt@goodmis.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: tracepoint filter problems
Message-ID: <20151103011324.GG21609@kernel.org>
References: <20151029152742.GB2923@kernel.org>
 <20151102095051.GN17308@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151102095051.GN17308@twins.programming.kicks-ass.net>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Nov 02, 2015 at 10:50:51AM +0100, Peter Zijlstra escreveu:
> On Thu, Oct 29, 2015 at 12:27:42PM -0300, Arnaldo Carvalho de Melo wrote:
> > In the example below 'perf trace' will ask to see just the 'open' syscall, and
> > it works for the started workload, namely 'perf record', but then it'll call
> > 'sleep 100000000000' and there the filter doesn't apply, bummer :-\

> > The inherit bit is set, sure, as we can see when adding -vv to the 'perf trace'
> > call, ideas?
 
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6939,6 +6939,10 @@ static int perf_tp_filter_match(struct p
>  {
>  	void *record = data->raw->data;
>  
> +	/* only top level events have filters set */
> +	if (event->parent)
> +		event = event->parent;
> +
>  	if (likely(!event->filter) || filter_match_preds(event->filter, record))
>  		return 1;
>  	return 0;

Thank you!

Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>

  [root@felicio ~]# trace -e bpf,nanosleep perf record -e /tmp/foo.o sleep 1
     385.246 ( 0.062 ms): perf/13761 bpf(cmd: PROG_LOAD, uattr: 0x7ffd9900ac90, size: 48) = 3
    1424.278 (999.497 ms): sleep/13762 nanosleep(rqtp: 0x7ffd4583a6e0                   ) = 0
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.012 MB perf.data ]
  [root@felicio ~]#

- Arnaldo