From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754673AbbKCBfz (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Nov 2015 20:35:55 -0500
Received: from mail-pa0-f50.google.com ([209.85.220.50]:34908 "EHLO
	mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754637AbbKCBfs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Nov 2015 20:35:48 -0500
Date: Tue, 3 Nov 2015 10:35:35 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>
Subject: Re: [RFC/PATCH 0/4] perf report: Support folded callchain output (v2)
Message-ID: <20151103013535.GD11498@danjae.kornet>
References: <1446469069-16223-1-git-send-email-namhyung@kernel.org>
 <CAE40pdcw_keB5fEUz--kDYxQpkGP8V5ybxOUiRBj1MJLFDo39A@mail.gmail.com>
 <20151102213021.GA21609@kernel.org>
 <20151102221204.GB10949@danjae.kornet>
 <20151102222842.GB21609@kernel.org>
 <20151102224927.GA11498@danjae.kornet>
 <20151102230436.GD21609@kernel.org>
 <20151102234606.GB11498@danjae.kornet>
 <20151103004647.GE21609@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151103004647.GE21609@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 02, 2015 at 09:46:47PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 03, 2015 at 08:46:06AM +0900, Namhyung Kim escreveu:
> > On Mon, Nov 02, 2015 at 08:04:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > > I still think that this is a 'perf report' thing, but one that is
> > > centered in callchains, and that is to be consumed by scripts, not
> > > humans.
>  
> > Agreed.
>  
> > I'm just looking for a way to support it with minimal change. :)
> 
> Hey, me too. A --no-hists flag looks like a quickie, no need to isolate
> callchain code, or anything like that, just one long option switch and
> we get what we need.

Hmm.. okay.  Let me think about the --no-hists flags then.

What do you want to do if the --no-hists flags is used without folded
callchain mode or other than --stdio?

And if you want to print other info in the callchains, what would be
the output of non-folded mode?

I think the simplest solution would be supporting the folded mode only
and error out other cases.  Is it ok to you?

Thanks,
Namhyung