From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932106AbbKCCc5 (ORCPT ); Mon, 2 Nov 2015 21:32:57 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:56085 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbbKCCct (ORCPT ); Mon, 2 Nov 2015 21:32:49 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Tue, 3 Nov 2015 11:32:51 +0900 From: Minchan Kim To: Hugh Dickins CC: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Johannes Weiner , zhangyanfei@cn.fujitsu.com, Rik van Riel , Mel Gorman , KOSAKI Motohiro , David Miller , "Darrick J. Wong" , Roland Dreier , Jason Evans , Daniel Micay , "Kirill A. Shutemov" , Michal Hocko , yalin.wang2010@gmail.com, Shaohua Li , Chen Gang , "rth@twiddle.net" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , Ralf Baechle , "jejb@parisc-linux.org" , "deller@gmx.de" , "chris@zankel.net" , "jcmvbkbc@gmail.com" , Arnd Bergmann , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Message-ID: <20151103023250.GH17906@bbox> References: <1446188504-28023-1-git-send-email-minchan@kernel.org> <1446188504-28023-4-git-send-email-minchan@kernel.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB04/LGE/LG Group(Release 8.5.3FP3HF583 | August 9, 2013) at 2015/11/03 11:32:46, Serialize by Router on LGEKRMHUB04/LGE/LG Group(Release 8.5.3FP3HF583 | August 9, 2013) at 2015/11/03 11:32:47, Serialize complete at 2015/11/03 11:32:47 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2015 at 04:08:27PM -0800, Hugh Dickins wrote: > On Fri, 30 Oct 2015, Minchan Kim wrote: > > From: Chen Gang > > > > For uapi, need try to let all macros have same value, and MADV_FREE is > > added into main branch recently, so need redefine MADV_FREE for it. > > > > At present, '8' can be shared with all architectures, so redefine it to > > '8'. > > > > Cc: rth@twiddle.net , > > Cc: ink@jurassic.park.msu.ru > > Cc: mattst88@gmail.com > > Cc: Ralf Baechle > > Cc: jejb@parisc-linux.org > > Cc: deller@gmx.de > > Cc: chris@zankel.net > > Cc: jcmvbkbc@gmail.com > > Cc: Arnd Bergmann > > Cc: linux-arch@vger.kernel.org > > Cc: linux-api@vger.kernel.org > > Acked-by: Minchan Kim > > Signed-off-by: Chen Gang > > Let me add > Acked-by: Hugh Dickins > to this one too. > > But I have extended your mail's Cc list: Darrick pointed out earlier > that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h, > and that was in the kernel's sparc mman.h up until 2.6.25. I doubt > that presents any obstacle nowadays, but Dave Miller should be Cc'ed. > > I was a little suspicious that 8 is available for MADV_FREE: why did > the common/generic parameters start at 9 instead of 8 back in 2.6.16? > I think the answer is that we had MADV_REMOVE coming in from one > direction, and MADV_DONTFORK coming from another direction, and when > Roland looked for where to start the commons for MADV_DONTFORK, it > appeared that 8 was occupied - by MADV_REMOVE; then a little later > MADV_REMOVE was shifted to become the first of the commons, at 9. Thanks for Ack, Ccing relevant people and history! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Date: Tue, 3 Nov 2015 11:32:51 +0900 Message-ID: <20151103023250.GH17906@bbox> References: <1446188504-28023-1-git-send-email-minchan@kernel.org> <1446188504-28023-4-git-send-email-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: In-Reply-To: Content-Disposition: inline Sender: sparclinux-owner@vger.kernel.org To: Hugh Dickins Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Johannes Weiner , zhangyanfei@cn.fujitsu.com, Rik van Riel , Mel Gorman , KOSAKI Motohiro , David Miller , "Darrick J. Wong" , Roland Dreier , Jason Evans , Daniel Micay , "Kirill A. Shutemov" , Michal Hocko , yalin.wang2010@gmail.com, Shaohua Li , Chen Gang , "rth@twiddle.net" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , Ralf Baechle , jejb@parisc-linu List-Id: linux-api@vger.kernel.org On Sun, Nov 01, 2015 at 04:08:27PM -0800, Hugh Dickins wrote: > On Fri, 30 Oct 2015, Minchan Kim wrote: > > From: Chen Gang > > > > For uapi, need try to let all macros have same value, and MADV_FREE is > > added into main branch recently, so need redefine MADV_FREE for it. > > > > At present, '8' can be shared with all architectures, so redefine it to > > '8'. > > > > Cc: rth@twiddle.net , > > Cc: ink@jurassic.park.msu.ru > > Cc: mattst88@gmail.com > > Cc: Ralf Baechle > > Cc: jejb@parisc-linux.org > > Cc: deller@gmx.de > > Cc: chris@zankel.net > > Cc: jcmvbkbc@gmail.com > > Cc: Arnd Bergmann > > Cc: linux-arch@vger.kernel.org > > Cc: linux-api@vger.kernel.org > > Acked-by: Minchan Kim > > Signed-off-by: Chen Gang > > Let me add > Acked-by: Hugh Dickins > to this one too. > > But I have extended your mail's Cc list: Darrick pointed out earlier > that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h, > and that was in the kernel's sparc mman.h up until 2.6.25. I doubt > that presents any obstacle nowadays, but Dave Miller should be Cc'ed. > > I was a little suspicious that 8 is available for MADV_FREE: why did > the common/generic parameters start at 9 instead of 8 back in 2.6.16? > I think the answer is that we had MADV_REMOVE coming in from one > direction, and MADV_DONTFORK coming from another direction, and when > Roland looked for where to start the commons for MADV_DONTFORK, it > appeared that 8 was occupied - by MADV_REMOVE; then a little later > MADV_REMOVE was shifted to become the first of the commons, at 9. Thanks for Ack, Ccing relevant people and history! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Date: Tue, 03 Nov 2015 02:32:51 +0000 Subject: Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Message-Id: <20151103023250.GH17906@bbox> List-Id: References: <1446188504-28023-1-git-send-email-minchan@kernel.org> <1446188504-28023-4-git-send-email-minchan@kernel.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hugh Dickins Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Johannes Weiner , zhangyanfei@cn.fujitsu.com, Rik van Riel , Mel Gorman , KOSAKI Motohiro , David Miller , "Darrick J. Wong" , Roland Dreier , Jason Evans , Daniel Micay , "Kirill A. Shutemov" , Michal Hocko , yalin.wang2010@gmail.com, Shaohua Li , Chen Gang , "rth@twiddle.net" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , Ralf Baechle , jejb@parisc-linu On Sun, Nov 01, 2015 at 04:08:27PM -0800, Hugh Dickins wrote: > On Fri, 30 Oct 2015, Minchan Kim wrote: > > From: Chen Gang > > > > For uapi, need try to let all macros have same value, and MADV_FREE is > > added into main branch recently, so need redefine MADV_FREE for it. > > > > At present, '8' can be shared with all architectures, so redefine it to > > '8'. > > > > Cc: rth@twiddle.net , > > Cc: ink@jurassic.park.msu.ru > > Cc: mattst88@gmail.com > > Cc: Ralf Baechle > > Cc: jejb@parisc-linux.org > > Cc: deller@gmx.de > > Cc: chris@zankel.net > > Cc: jcmvbkbc@gmail.com > > Cc: Arnd Bergmann > > Cc: linux-arch@vger.kernel.org > > Cc: linux-api@vger.kernel.org > > Acked-by: Minchan Kim > > Signed-off-by: Chen Gang > > Let me add > Acked-by: Hugh Dickins > to this one too. > > But I have extended your mail's Cc list: Darrick pointed out earlier > that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h, > and that was in the kernel's sparc mman.h up until 2.6.25. I doubt > that presents any obstacle nowadays, but Dave Miller should be Cc'ed. > > I was a little suspicious that 8 is available for MADV_FREE: why did > the common/generic parameters start at 9 instead of 8 back in 2.6.16? > I think the answer is that we had MADV_REMOVE coming in from one > direction, and MADV_DONTFORK coming from another direction, and when > Roland looked for where to start the commons for MADV_DONTFORK, it > appeared that 8 was occupied - by MADV_REMOVE; then a little later > MADV_REMOVE was shifted to become the first of the commons, at 9. Thanks for Ack, Ccing relevant people and history! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by kanga.kvack.org (Postfix) with ESMTP id 1063B82F64 for ; Mon, 2 Nov 2015 21:32:53 -0500 (EST) Received: by pabfh17 with SMTP id fh17so4074242pab.0 for ; Mon, 02 Nov 2015 18:32:52 -0800 (PST) Received: from lgeamrelo13.lge.com (LGEAMRELO13.lge.com. [156.147.23.53]) by mx.google.com with ESMTPS id em5si39387239pbd.203.2015.11.02.18.32.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Nov 2015 18:32:52 -0800 (PST) Date: Tue, 3 Nov 2015 11:32:51 +0900 From: Minchan Kim Subject: Re: [PATCH 3/8] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Message-ID: <20151103023250.GH17906@bbox> References: <1446188504-28023-1-git-send-email-minchan@kernel.org> <1446188504-28023-4-git-send-email-minchan@kernel.org> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Johannes Weiner , zhangyanfei@cn.fujitsu.com, Rik van Riel , Mel Gorman , KOSAKI Motohiro , David Miller , "Darrick J. Wong" , Roland Dreier , Jason Evans , Daniel Micay , "Kirill A. Shutemov" , Michal Hocko , yalin.wang2010@gmail.com, Shaohua Li , Chen Gang , "rth@twiddle.net" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , Ralf Baechle , "jejb@parisc-linux.org" , "deller@gmx.de" , "chris@zankel.net" , "jcmvbkbc@gmail.com" , Arnd Bergmann , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org On Sun, Nov 01, 2015 at 04:08:27PM -0800, Hugh Dickins wrote: > On Fri, 30 Oct 2015, Minchan Kim wrote: > > From: Chen Gang > > > > For uapi, need try to let all macros have same value, and MADV_FREE is > > added into main branch recently, so need redefine MADV_FREE for it. > > > > At present, '8' can be shared with all architectures, so redefine it to > > '8'. > > > > Cc: rth@twiddle.net , > > Cc: ink@jurassic.park.msu.ru > > Cc: mattst88@gmail.com > > Cc: Ralf Baechle > > Cc: jejb@parisc-linux.org > > Cc: deller@gmx.de > > Cc: chris@zankel.net > > Cc: jcmvbkbc@gmail.com > > Cc: Arnd Bergmann > > Cc: linux-arch@vger.kernel.org > > Cc: linux-api@vger.kernel.org > > Acked-by: Minchan Kim > > Signed-off-by: Chen Gang > > Let me add > Acked-by: Hugh Dickins > to this one too. > > But I have extended your mail's Cc list: Darrick pointed out earlier > that dietlibc has a Solaris #define MADV_FREE 0x5 in its mman.h, > and that was in the kernel's sparc mman.h up until 2.6.25. I doubt > that presents any obstacle nowadays, but Dave Miller should be Cc'ed. > > I was a little suspicious that 8 is available for MADV_FREE: why did > the common/generic parameters start at 9 instead of 8 back in 2.6.16? > I think the answer is that we had MADV_REMOVE coming in from one > direction, and MADV_DONTFORK coming from another direction, and when > Roland looked for where to start the commons for MADV_DONTFORK, it > appeared that 8 was occupied - by MADV_REMOVE; then a little later > MADV_REMOVE was shifted to become the first of the commons, at 9. Thanks for Ack, Ccing relevant people and history! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org