From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754886AbbKCPDK (ORCPT ); Tue, 3 Nov 2015 10:03:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40475 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbbKCPDI (ORCPT ); Tue, 3 Nov 2015 10:03:08 -0500 Date: Tue, 3 Nov 2015 09:03:06 -0600 From: Josh Poimboeuf To: Petr Mladek Cc: Miroslav Benes , Chris J Arges , live-patching@vger.kernel.org, jeyu@redhat.com, Seth Jennings , Jiri Kosina , Vojtech Pavlik , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] livepatch: old_name.number scheme in livepatch sysfs directory Message-ID: <20151103150306.GI27488@treble.redhat.com> References: <20151102203241.GF27488@treble.redhat.com> <1446505187-28970-1-git-send-email-chris.j.arges@canonical.com> <20151103124440.GK2599@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151103124440.GK2599@pathway.suse.cz> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 03, 2015 at 01:44:41PM +0100, Petr Mladek wrote: > Also I would omit the suffix at all when it is the first occurrence. > It will cause that unique symbols will not be numbered. That would make parsing the entry unnecessarily harder and more error-prone. I think it should always have the suffix, so it's consistent and there are no surprises. -- Josh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Poimboeuf Subject: Re: [PATCH v2] livepatch: old_name.number scheme in livepatch sysfs directory Date: Tue, 3 Nov 2015 09:03:06 -0600 Message-ID: <20151103150306.GI27488@treble.redhat.com> References: <20151102203241.GF27488@treble.redhat.com> <1446505187-28970-1-git-send-email-chris.j.arges@canonical.com> <20151103124440.GK2599@pathway.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20151103124440.GK2599-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Petr Mladek Cc: Miroslav Benes , Chris J Arges , live-patching-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jeyu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Seth Jennings , Jiri Kosina , Vojtech Pavlik , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Tue, Nov 03, 2015 at 01:44:41PM +0100, Petr Mladek wrote: > Also I would omit the suffix at all when it is the first occurrence. > It will cause that unique symbols will not be numbered. That would make parsing the entry unnecessarily harder and more error-prone. I think it should always have the suffix, so it's consistent and there are no surprises. -- Josh