From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 32/43] drm/i915: Clean up LVDS register
 handling
Date: Wed, 4 Nov 2015 18:59:06 +0200
Message-ID: <20151104165906.GV4437@intel.com>
References: <1442595836-23981-1-git-send-email-ville.syrjala@linux.intel.com>
 <1442595836-23981-33-git-send-email-ville.syrjala@linux.intel.com>
 <20151101153357.GA21423@wunner.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2888E6E240
 for <intel-gfx@lists.freedesktop.org>; Wed,  4 Nov 2015 08:59:09 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20151101153357.GA21423@wunner.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gU3VuLCBOb3YgMDEsIDIwMTUgYXQgMDQ6MzM6NTdQTSArMDEwMCwgTHVrYXMgV3VubmVyIHdy
b3RlOgo+IEhpIFZpbGxlLAo+IAo+IE9uIEZyaSwgU2VwIDE4LCAyMDE1IGF0IDA4OjAzOjQ1UE0g
KzAzMDAsIHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gRnJvbTogVmls
bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gS2Vl
cCBzaW5nbGUgJ2x2ZHNfcmVnJyBhbmQgJ2x2ZHMnIHZhcmlhYmxlIGFyb3VuZCBpbgo+ID4gaW50
ZWxfbHZkc19pbml0KCksIGFuZCByZWFkIGl0IGp1c3Qgb25jZSBhdCB0aGUgc3RhcnQuCj4gCj4g
SG0sIGlzIGl0IGludGVudGlvbmFsIHRoYXQgeW91IGRpZG4ndCBhbHNvIHJlcGxhY2UgdGhpcyBy
ZWdpc3RlciByZWFkb3V0Cj4gYXQgdGhlIGVuZCBvZiB0aGUgZnVuY3Rpb24/Cj4gCj4gCWx2ZHNf
ZW5jb2Rlci0+YTNfcG93ZXIgPSBJOTE1X1JFQUQobHZkc19lbmNvZGVyLT5yZWcpICYKPiAJCQkJ
IExWRFNfQTNfUE9XRVJfTUFTSzsKClNpbXBseSBkaWRuJ3Qgbm90aWNlIHRoYXQgYml0LgoKPiAK
PiAoU29ycnksIEkgb25seSBub3RpY2VkIHRoaXMgdG9kYXksIHBvc3QtbWVyZ2UsIHdoaWxlIHJl
YmFzaW5nIG15IExWRFMKPiByZXByb2Jpbmcgc3R1ZmYuKQo+IAo+IEJlc3QgcmVnYXJkcywKPiAK
PiBMdWthcwo+IAo+ID4gCj4gPiBBbHNvIGludGVsX2x2ZHNfZ2V0X2NvbmZpZygpIGRvZXNuJ3Qg
bmVlZCB0byBmaWd1cmUgb3V0IHdoaWNoIHJlZyB0byB1c2UKPiA+IHNpbmNlIGl0IGNhbiBqdXN0
IGNvbnN1bHQgbHZkc19lbmNvZGVyLT5yZWcuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxl
IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBk
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMgfCAzMCArKysrKysrKysrKysrKy0tLS0t
LS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMTYgZGVs
ZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9sdmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiA+IGluZGV4IDJj
MmQxZjAuLjM1YmFkNzEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9sdmRzLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYwo+ID4g
QEAgLTk4LDE1ICs5OCwxMSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9sdmRzX2dldF9jb25maWcoc3Ry
dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiAgewo+ID4gIAlzdHJ1Y3QgZHJtX2Rldmlj
ZSAqZGV2ID0gZW5jb2Rlci0+YmFzZS5kZXY7Cj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl
ICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiAtCXUzMiBsdmRzX3JlZywgdG1wLCBm
bGFncyA9IDA7Cj4gPiArCXN0cnVjdCBpbnRlbF9sdmRzX2VuY29kZXIgKmx2ZHNfZW5jb2RlciA9
IHRvX2x2ZHNfZW5jb2RlcigmZW5jb2Rlci0+YmFzZSk7Cj4gPiArCXUzMiB0bXAsIGZsYWdzID0g
MDsKPiA+ICAJaW50IGRvdGNsb2NrOwo+ID4gIAo+ID4gLQlpZiAoSEFTX1BDSF9TUExJVChkZXYp
KQo+ID4gLQkJbHZkc19yZWcgPSBQQ0hfTFZEUzsKPiA+IC0JZWxzZQo+ID4gLQkJbHZkc19yZWcg
PSBMVkRTOwo+ID4gLQo+ID4gLQl0bXAgPSBJOTE1X1JFQUQobHZkc19yZWcpOwo+ID4gKwl0bXAg
PSBJOTE1X1JFQUQobHZkc19lbmNvZGVyLT5yZWcpOwo+ID4gIAlpZiAodG1wICYgTFZEU19IU1lO
Q19QT0xBUklUWSkKPiA+ICAJCWZsYWdzIHw9IERSTV9NT0RFX0ZMQUdfTkhTWU5DOwo+ID4gIAll
bHNlCj4gPiBAQCAtOTQ0LDYgKzk0MCw3IEBAIHZvaWQgaW50ZWxfbHZkc19pbml0KHN0cnVjdCBk
cm1fZGV2aWNlICpkZXYpCj4gPiAgCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpkb3duY2xvY2tf
bW9kZSA9IE5VTEw7Cj4gPiAgCXN0cnVjdCBlZGlkICplZGlkOwo+ID4gIAlzdHJ1Y3QgZHJtX2Ny
dGMgKmNydGM7Cj4gPiArCXUzMiBsdmRzX3JlZzsKPiA+ICAJdTMyIGx2ZHM7Cj4gPiAgCWludCBw
aXBlOwo+ID4gIAl1OCBwaW47Cj4gPiBAQCAtOTY2LDggKzk2MywxNSBAQCB2b2lkIGludGVsX2x2
ZHNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gIAlpZiAoZG1pX2NoZWNrX3N5c3Rl
bShpbnRlbF9ub19sdmRzKSkKPiA+ICAJCXJldHVybjsKPiA+ICAKPiA+ICsJaWYgKEhBU19QQ0hf
U1BMSVQoZGV2KSkKPiA+ICsJCWx2ZHNfcmVnID0gUENIX0xWRFM7Cj4gPiArCWVsc2UKPiA+ICsJ
CWx2ZHNfcmVnID0gTFZEUzsKPiA+ICsKPiA+ICsJbHZkcyA9IEk5MTVfUkVBRChsdmRzX3JlZyk7
Cj4gPiArCj4gPiAgCWlmIChIQVNfUENIX1NQTElUKGRldikpIHsKPiA+IC0JCWlmICgoSTkxNV9S
RUFEKFBDSF9MVkRTKSAmIExWRFNfREVURUNURUQpID09IDApCj4gPiArCQlpZiAoKGx2ZHMgJiBM
VkRTX0RFVEVDVEVEKSA9PSAwKQo+ID4gIAkJCXJldHVybjsKPiA+ICAJCWlmIChkZXZfcHJpdi0+
dmJ0LmVkcF9zdXBwb3J0KSB7Cj4gPiAgCQkJRFJNX0RFQlVHX0tNUygiZGlzYWJsZSBMVkRTIGZv
ciBlRFAgc3VwcG9ydFxuIik7Cj4gPiBAQCAtOTc3LDggKzk4MSw3IEBAIHZvaWQgaW50ZWxfbHZk
c19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgCj4gPiAgCXBpbiA9IEdNQlVTX1BJ
Tl9QQU5FTDsKPiA+ICAJaWYgKCFsdmRzX2lzX3ByZXNlbnRfaW5fdmJ0KGRldiwgJnBpbikpIHsK
PiA+IC0JCXUzMiByZWcgPSBIQVNfUENIX1NQTElUKGRldikgPyBQQ0hfTFZEUyA6IExWRFM7Cj4g
PiAtCQlpZiAoKEk5MTVfUkVBRChyZWcpICYgTFZEU19QT1JUX0VOKSA9PSAwKSB7Cj4gPiArCQlp
ZiAoKGx2ZHMgJiBMVkRTX1BPUlRfRU4pID09IDApIHsKPiA+ICAJCQlEUk1fREVCVUdfS01TKCJM
VkRTIGlzIG5vdCBwcmVzZW50IGluIFZCVFxuIik7Cj4gPiAgCQkJcmV0dXJuOwo+ID4gIAkJfQo+
ID4gQEAgLTEwNTUsMTEgKzEwNTgsNyBAQCB2b2lkIGludGVsX2x2ZHNfaW5pdChzdHJ1Y3QgZHJt
X2RldmljZSAqZGV2KQo+ID4gIAljb25uZWN0b3ItPmludGVybGFjZV9hbGxvd2VkID0gZmFsc2U7
Cj4gPiAgCWNvbm5lY3Rvci0+ZG91Ymxlc2Nhbl9hbGxvd2VkID0gZmFsc2U7Cj4gPiAgCj4gPiAt
CWlmIChIQVNfUENIX1NQTElUKGRldikpIHsKPiA+IC0JCWx2ZHNfZW5jb2Rlci0+cmVnID0gUENI
X0xWRFM7Cj4gPiAtCX0gZWxzZSB7Cj4gPiAtCQlsdmRzX2VuY29kZXItPnJlZyA9IExWRFM7Cj4g
PiAtCX0KPiA+ICsJbHZkc19lbmNvZGVyLT5yZWcgPSBsdmRzX3JlZzsKPiA+ICAKPiA+ICAJLyog
Y3JlYXRlIHRoZSBzY2FsaW5nIG1vZGUgcHJvcGVydHkgKi8KPiA+ICAJZHJtX21vZGVfY3JlYXRl
X3NjYWxpbmdfbW9kZV9wcm9wZXJ0eShkZXYpOwo+ID4gQEAgLTExNDAsNyArMTEzOSw2IEBAIHZv
aWQgaW50ZWxfbHZkc19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgCWlmIChIQVNf
UENIX1NQTElUKGRldikpCj4gPiAgCQlnb3RvIGZhaWxlZDsKPiA+ICAKPiA+IC0JbHZkcyA9IEk5
MTVfUkVBRChMVkRTKTsKPiA+ICAJcGlwZSA9IChsdmRzICYgTFZEU19QSVBFQl9TRUxFQ1QpID8g
MSA6IDA7Cj4gPiAgCWNydGMgPSBpbnRlbF9nZXRfY3J0Y19mb3JfcGlwZShkZXYsIHBpcGUpOwo+
ID4gIAo+ID4gLS0gCj4gPiAyLjQuNgo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl
bCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50
ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK