From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756385AbbKDXjH (ORCPT ); Wed, 4 Nov 2015 18:39:07 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:44479 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756263AbbKDXjF (ORCPT ); Wed, 4 Nov 2015 18:39:05 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 5 Nov 2015 08:39:10 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Hugh Dickins , Johannes Weiner , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Jason Evans , Daniel Micay , "Kirill A. Shutemov" , Shaohua Li , Michal Hocko , yalin.wang2010@gmail.com Subject: Re: [PATCH v2 01/13] mm: support madvise(MADV_FREE) Message-ID: <20151104233910.GA7357@bbox> References: <1446600367-7976-1-git-send-email-minchan@kernel.org> <1446600367-7976-2-git-send-email-minchan@kernel.org> <20151104021624.GA2476@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151104021624.GA2476@swordfish> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sergey, On Wed, Nov 04, 2015 at 11:16:24AM +0900, Sergey Senozhatsky wrote: > Hi Minchan, > > On (11/04/15 10:25), Minchan Kim wrote: > [..] > >+static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > >+ unsigned long end, struct mm_walk *walk) > >+ > ... > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > I think it makes sense to update pmd_trans_unstable() and > pmd_none_or_trans_huge_or_clear_bad() comments in asm-generic/pgtable.h > Because they explicitly mention MADV_DONTNEED only. Just a thought. Hmm, When I read comments(but actually I don't understand it 100%), it says pmd disappearing from MADV_DONTNEED with mmap_sem read-side lock. But MADV_FREE doesn't remove the pmd. So, I don't understand what I should add comment. Please suggest if I am missing something. > > > > @@ -379,6 +502,14 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > > return madvise_remove(vma, prev, start, end); > > case MADV_WILLNEED: > > return madvise_willneed(vma, prev, start, end); > > + case MADV_FREE: > > + /* > > + * XXX: In this implementation, MADV_FREE works like > ^^^^ > XXX What does it mean? > > > + * MADV_DONTNEED on swapless system or full swap. > > + */ > > + if (get_nr_swap_pages() > 0) > > + return madvise_free(vma, prev, start, end); > > + /* passthrough */ > > -ss From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH v2 01/13] mm: support madvise(MADV_FREE) Date: Thu, 5 Nov 2015 08:39:10 +0900 Message-ID: <20151104233910.GA7357@bbox> References: <1446600367-7976-1-git-send-email-minchan@kernel.org> <1446600367-7976-2-git-send-email-minchan@kernel.org> <20151104021624.GA2476@swordfish> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151104021624.GA2476@swordfish> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergey Senozhatsky Cc: Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Michael Kerrisk , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hugh Dickins , Johannes Weiner , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Jason Evans , Daniel Micay , "Kirill A. Shutemov" , Shaohua Li , Michal Hocko , yalin.wang2010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-api@vger.kernel.org Hi Sergey, On Wed, Nov 04, 2015 at 11:16:24AM +0900, Sergey Senozhatsky wrote: > Hi Minchan, > > On (11/04/15 10:25), Minchan Kim wrote: > [..] > >+static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > >+ unsigned long end, struct mm_walk *walk) > >+ > ... > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > I think it makes sense to update pmd_trans_unstable() and > pmd_none_or_trans_huge_or_clear_bad() comments in asm-generic/pgtable.h > Because they explicitly mention MADV_DONTNEED only. Just a thought. Hmm, When I read comments(but actually I don't understand it 100%), it says pmd disappearing from MADV_DONTNEED with mmap_sem read-side lock. But MADV_FREE doesn't remove the pmd. So, I don't understand what I should add comment. Please suggest if I am missing something. > > > > @@ -379,6 +502,14 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > > return madvise_remove(vma, prev, start, end); > > case MADV_WILLNEED: > > return madvise_willneed(vma, prev, start, end); > > + case MADV_FREE: > > + /* > > + * XXX: In this implementation, MADV_FREE works like > ^^^^ > XXX What does it mean? > > > + * MADV_DONTNEED on swapless system or full swap. > > + */ > > + if (get_nr_swap_pages() > 0) > > + return madvise_free(vma, prev, start, end); > > + /* passthrough */ > > -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 4DCDA82F64 for ; Wed, 4 Nov 2015 18:39:11 -0500 (EST) Received: by pacdm15 with SMTP id dm15so42627240pac.3 for ; Wed, 04 Nov 2015 15:39:11 -0800 (PST) Received: from lgeamrelo11.lge.com (LGEAMRELO11.lge.com. [156.147.23.51]) by mx.google.com with ESMTPS id c5si2988366pas.41.2015.11.04.15.39.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Nov 2015 15:39:10 -0800 (PST) Date: Thu, 5 Nov 2015 08:39:10 +0900 From: Minchan Kim Subject: Re: [PATCH v2 01/13] mm: support madvise(MADV_FREE) Message-ID: <20151104233910.GA7357@bbox> References: <1446600367-7976-1-git-send-email-minchan@kernel.org> <1446600367-7976-2-git-send-email-minchan@kernel.org> <20151104021624.GA2476@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151104021624.GA2476@swordfish> Sender: owner-linux-mm@kvack.org List-ID: To: Sergey Senozhatsky Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , linux-api@vger.kernel.org, Hugh Dickins , Johannes Weiner , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Jason Evans , Daniel Micay , "Kirill A. Shutemov" , Shaohua Li , Michal Hocko , yalin.wang2010@gmail.com Hi Sergey, On Wed, Nov 04, 2015 at 11:16:24AM +0900, Sergey Senozhatsky wrote: > Hi Minchan, > > On (11/04/15 10:25), Minchan Kim wrote: > [..] > >+static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > >+ unsigned long end, struct mm_walk *walk) > >+ > ... > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > I think it makes sense to update pmd_trans_unstable() and > pmd_none_or_trans_huge_or_clear_bad() comments in asm-generic/pgtable.h > Because they explicitly mention MADV_DONTNEED only. Just a thought. Hmm, When I read comments(but actually I don't understand it 100%), it says pmd disappearing from MADV_DONTNEED with mmap_sem read-side lock. But MADV_FREE doesn't remove the pmd. So, I don't understand what I should add comment. Please suggest if I am missing something. > > > > @@ -379,6 +502,14 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > > return madvise_remove(vma, prev, start, end); > > case MADV_WILLNEED: > > return madvise_willneed(vma, prev, start, end); > > + case MADV_FREE: > > + /* > > + * XXX: In this implementation, MADV_FREE works like > ^^^^ > XXX What does it mean? > > > + * MADV_DONTNEED on swapless system or full swap. > > + */ > > + if (get_nr_swap_pages() > 0) > > + return madvise_free(vma, prev, start, end); > > + /* passthrough */ > > -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org