From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gavin Shan Subject: Re: [PATCH v7 04/50] powerpc/powernv: Cleanup on pnv_pci_ioda_controller_ops Date: Fri, 6 Nov 2015 12:09:51 +1100 Message-ID: <20151106010951.GA4601@gwshan> References: <1446642770-4681-1-git-send-email-gwshan@linux.vnet.ibm.com> <1446642770-4681-5-git-send-email-gwshan@linux.vnet.ibm.com> <87vb9ghyij.fsf@gamma.ozlabs.ibm.com> Reply-To: Gavin Shan Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87vb9ghyij.fsf@gamma.ozlabs.ibm.com> Sender: linux-pci-owner@vger.kernel.org To: Daniel Axtens Cc: Gavin Shan , linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, aik@ozlabs.ru, linux-pci@vger.kernel.org, panto@antoniou-consulting.com, grant.likely@linaro.org, robherring2@gmail.com, bhelgaas@google.com, frowand.list@gmail.com List-Id: devicetree@vger.kernel.org On Fri, Nov 06, 2015 at 09:28:20AM +1100, Daniel Axtens wrote: >Gavin Shan writes: > >> This cleans up on pnv_pci_ioda_controller_ops struct to use tab >> instead of space indent of statement to avoid complains from >> scripts/checkpatch.pl. No logical changes introduced. > >Oh, that was my code :/ Sorry I missed that, thanks for cleaning it up! > >Reviewed-by: Daniel Axtens > nah, that's fine, Daniel. You might be saying: I didn't review your code carefully enough, which leaves me the chance to clean it up :-) Thanks, Gavin >> >> Signed-off-by: Gavin Shan >> --- >> arch/powerpc/platforms/powernv/pci-ioda.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c >> index 2e2bedb..aa3645c 100644 >> --- a/arch/powerpc/platforms/powernv/pci-ioda.c >> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c >> @@ -3064,17 +3064,17 @@ static void pnv_pci_ioda_shutdown(struct pci_controller *hose) >> } >> >> static const struct pci_controller_ops pnv_pci_ioda_controller_ops = { >> - .dma_dev_setup = pnv_pci_dma_dev_setup, >> + .dma_dev_setup = pnv_pci_dma_dev_setup, >> #ifdef CONFIG_PCI_MSI >> - .setup_msi_irqs = pnv_setup_msi_irqs, >> - .teardown_msi_irqs = pnv_teardown_msi_irqs, >> + .setup_msi_irqs = pnv_setup_msi_irqs, >> + .teardown_msi_irqs = pnv_teardown_msi_irqs, >> #endif >> - .enable_device_hook = pnv_pci_enable_device_hook, >> - .window_alignment = pnv_pci_window_alignment, >> - .reset_secondary_bus = pnv_pci_reset_secondary_bus, >> - .dma_set_mask = pnv_pci_ioda_dma_set_mask, >> - .dma_get_required_mask = pnv_pci_ioda_dma_get_required_mask, >> - .shutdown = pnv_pci_ioda_shutdown, >> + .enable_device_hook = pnv_pci_enable_device_hook, >> + .window_alignment = pnv_pci_window_alignment, >> + .reset_secondary_bus = pnv_pci_reset_secondary_bus, >> + .dma_set_mask = pnv_pci_ioda_dma_set_mask, >> + .dma_get_required_mask = pnv_pci_ioda_dma_get_required_mask, >> + .shutdown = pnv_pci_ioda_shutdown, >> }; >> >> static void __init pnv_pci_init_ioda_phb(struct device_node *np, >> -- >> 2.1.0 >> >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/linuxppc-dev >