From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031686AbbKFCSh (ORCPT ); Thu, 5 Nov 2015 21:18:37 -0500 Received: from mail.kernel.org ([198.145.29.136]:53846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031061AbbKFCSf (ORCPT ); Thu, 5 Nov 2015 21:18:35 -0500 Date: Thu, 5 Nov 2015 20:18:29 -0600 From: Rob Herring To: Chris Zhong Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 08/13] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver Message-ID: <20151106021829.GA4810@rob-hp-laptop> References: <1446296170-3702-1-git-send-email-zyw@rock-chips.com> <1446296170-3702-9-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446296170-3702-9-git-send-email-zyw@rock-chips.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 31, 2015 at 08:56:04PM +0800, Chris Zhong wrote: > add device tree bindings for rk3288 specific Synopsys DW MIPI DSI driver > > Signed-off-by: Chris Zhong > --- > > Changes in v2: None > > .../bindings/video/dw_mipi_dsi_rockchip.txt | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt > > diff --git a/Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt > new file mode 100644 > index 0000000..4dea804 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt Please move to bindings/display/rockchip/ > @@ -0,0 +1,56 @@ > +Rockchip specific extensions to the Synopsys Designware MIPI DSI > +================================ > + > +Required properties: > +- compatible: "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi". > +- rockchip,grf: this soc should set GRF regs to mux vopl/vopb. > +- ports: contain a port node with endpoint definitions as defined in [1]. > + For vopb,set the reg = <0> and set the reg = <1> for vopl. > + > +For more required properties, please refer to [2]. > + > +[1] Documentation/devicetree/bindings/media/video-interfaces.txt > +[2] Documentation/devicetree/bindings/drm/bridge/dw_mipi_dsi.txt This needs to be updated too. > + > +Example: > + mipi_dsi: mipi@ff960000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi"; > + reg = <0xff960000 0x4000>; > + interrupts = ; > + clocks = <&cru SCLK_MIPI_24M>, <&cru PCLK_MIPI_DSI0>; > + clock-names = "ref", "pclk"; > + rockchip,grf = <&grf>; > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + mipi_in: port { > + #address-cells = <1>; > + #size-cells = <0>; > + mipi_in_vopb: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vopb_out_mipi>; > + }; > + mipi_in_vopl: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&vopl_out_mipi>; > + }; > + }; > + }; > + > + panel { > + compatible ="boe,tv080wum-nl0"; > + reg = <0>; > + > + enable-gpios = <&gpio7 3 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_en>; > + backlight = <&backlight>; > + status = "okay"; > + }; > + }; > -- > 2.6.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Thu, 5 Nov 2015 20:18:29 -0600 Subject: [PATCH v2 08/13] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver In-Reply-To: <1446296170-3702-9-git-send-email-zyw@rock-chips.com> References: <1446296170-3702-1-git-send-email-zyw@rock-chips.com> <1446296170-3702-9-git-send-email-zyw@rock-chips.com> Message-ID: <20151106021829.GA4810@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Oct 31, 2015 at 08:56:04PM +0800, Chris Zhong wrote: > add device tree bindings for rk3288 specific Synopsys DW MIPI DSI driver > > Signed-off-by: Chris Zhong > --- > > Changes in v2: None > > .../bindings/video/dw_mipi_dsi_rockchip.txt | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt > > diff --git a/Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt > new file mode 100644 > index 0000000..4dea804 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/dw_mipi_dsi_rockchip.txt Please move to bindings/display/rockchip/ > @@ -0,0 +1,56 @@ > +Rockchip specific extensions to the Synopsys Designware MIPI DSI > +================================ > + > +Required properties: > +- compatible: "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi". > +- rockchip,grf: this soc should set GRF regs to mux vopl/vopb. > +- ports: contain a port node with endpoint definitions as defined in [1]. > + For vopb,set the reg = <0> and set the reg = <1> for vopl. > + > +For more required properties, please refer to [2]. > + > +[1] Documentation/devicetree/bindings/media/video-interfaces.txt > +[2] Documentation/devicetree/bindings/drm/bridge/dw_mipi_dsi.txt This needs to be updated too. > + > +Example: > + mipi_dsi: mipi at ff960000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi"; > + reg = <0xff960000 0x4000>; > + interrupts = ; > + clocks = <&cru SCLK_MIPI_24M>, <&cru PCLK_MIPI_DSI0>; > + clock-names = "ref", "pclk"; > + rockchip,grf = <&grf>; > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + mipi_in: port { > + #address-cells = <1>; > + #size-cells = <0>; > + mipi_in_vopb: endpoint at 0 { > + reg = <0>; > + remote-endpoint = <&vopb_out_mipi>; > + }; > + mipi_in_vopl: endpoint at 1 { > + reg = <1>; > + remote-endpoint = <&vopl_out_mipi>; > + }; > + }; > + }; > + > + panel { > + compatible ="boe,tv080wum-nl0"; > + reg = <0>; > + > + enable-gpios = <&gpio7 3 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_en>; > + backlight = <&backlight>; > + status = "okay"; > + }; > + }; > -- > 2.6.2 >