From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbbKGLPw (ORCPT ); Sat, 7 Nov 2015 06:15:52 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:42039 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbbKGLPv (ORCPT ); Sat, 7 Nov 2015 06:15:51 -0500 Date: Sat, 7 Nov 2015 14:15:24 +0300 From: Dan Carpenter To: "Simmons, James A." Cc: "'Shivani Bhardwaj'" , "gregkh@linuxfoundation.org" , "oleg.drokin@intel.com" , "devel@driverdev.osuosl.org" , "andreas.dilger@intel.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] Staging: lustre: module: Replace function calls Message-ID: <20151107111523.GG18797@mwanda> References: <1cdd091b39e2202a0810efe538ddd520da967ed4.1446830119.git.shivanib134@gmail.com> <29aacb945be3417d96c1ebc49d9eeb6c@EXCHCS32.ornl.gov> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29aacb945be3417d96c1ebc49d9eeb6c@EXCHCS32.ornl.gov> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 06, 2015 at 10:04:41PM +0000, Simmons, James A. wrote: > >From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf Of Shivani Bhardwaj > >Sent: Friday, November 06, 2015 12:18 PM > >To: gregkh@linuxfoundation.org > >Cc: oleg.drokin@intel.com; devel@driverdev.osuosl.org; andreas.dilger@intel.com; linux-kernel@vger.kernel.org > >Subject: [PATCH 1/3] Staging: lustre: module: Replace function calls > > > >Replace the calls of function cfs_trace_free_string_buffer() with > >kfree() as the former function is not required. > > > >Signed-off-by: Shivani Bhardwaj > >--- > > drivers/staging/lustre/lustre/libcfs/module.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Acked-by: James Simmons > > diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c > index 50e8fd2..516a9e7 100644 > --- a/drivers/staging/lustre/lustre/libcfs/module.c > +++ b/drivers/staging/lustre/lustre/libcfs/module.c > @@ -392,7 +392,7 @@ static int __proc_dobitmasks(void *data, int write, > } else { Why do your acks include the original diff without the "> " prefix? How are you even managing that trick? regards, dan carpenter