From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbbKGS6J (ORCPT ); Sat, 7 Nov 2015 13:58:09 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33819 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753551AbbKGS6H (ORCPT ); Sat, 7 Nov 2015 13:58:07 -0500 Date: Sat, 7 Nov 2015 10:58:03 -0800 From: Jeremiah Mahler To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Marcel Selhorst , David Safford , Mimi Zohar , "open list:KEYS-TRUSTED" , "open list:KEYS-TRUSTED" Subject: Re: [PATCH 08/10] tpm: seal/unseal for TPM 2.0 Message-ID: <20151107185803.GA3375@newt.localdomain> Mail-Followup-To: Jeremiah Mahler , Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Marcel Selhorst , David Safford , Mimi Zohar , "open list:KEYS-TRUSTED" , "open list:KEYS-TRUSTED" References: <1445020843-9382-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1445020843-9382-9-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445020843-9382-9-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jarkko, On Fri, Oct 16, 2015 at 09:40:27PM +0300, Jarkko Sakkinen wrote: > Added tpm_trusted_seal() and tpm_trusted_unseal() API for sealing > trusted keys. > > This patch implements basic sealing and unsealing functionality for > TPM 2.0: > > * Seal with a parent key using a 20 byte auth value. > * Unseal with a parent key using a 20 byte auth value. > > Signed-off-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm-interface.c | 76 ++++++++++++ > drivers/char/tpm/tpm.h | 15 ++- > drivers/char/tpm/tpm2-cmd.c | 250 ++++++++++++++++++++++++++++++++++++++- > include/keys/trusted-type.h | 2 +- > include/linux/tpm.h | 26 ++++ > 5 files changed, 366 insertions(+), 3 deletions(-) > This patch adds a lot of code but doesn't use any of it until later patches. This can make using 'git bisect' more difficult because it will point to the wrong patches. If this were my patch series I would combine this patch with the later ones that actually start using the code. [...] -- - Jeremiah Mahler