Re: [Qemu-devel] [PATCH 1/1] migration: qemu_savevm_state_cleanup becomes mandatory operation

From: Amit Shah <amit.shah@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	liang.z.li@intel.com, qemu-devel@nongnu.org,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] migration: qemu_savevm_state_cleanup becomes mandatory operation
Date: Mon, 9 Nov 2015 09:36:55 +0530	[thread overview]
Message-ID: <20151109040655.GA16185@grmbl.mre> (raw)
In-Reply-To: <1446910812-13044-1-git-send-email-den@openvz.org>

CC'ing Liang Li, author of the patch.

On (Sat) 07 Nov 2015 [18:40:12], Denis V. Lunev wrote:
> since commit
>     commit 94f5a43704129ca4995aa3385303c5ae225bde42
>     Author: Liang Li <liang.z.li@intel.com>
>     Date:   Mon Nov 2 15:37:00 2015 +0800
> 
>     migration: defer migration_end & blk_mig_cleanup
> 
> when actual .cleanup callbacks calling was removed from complete operations.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Amit Shah <amit.shah@redhat.com>
> ---
>  migration/savevm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/savevm.c b/migration/savevm.c
> index e05158d..9f2230f 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -942,8 +942,8 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp)
>          qemu_savevm_state_complete(f);
>          ret = qemu_file_get_error(f);
>      }
> +    qemu_savevm_state_cleanup();
>      if (ret != 0) {
> -        qemu_savevm_state_cleanup();
>          error_setg_errno(errp, -ret, "Error while writing VM state");
>      }
>      return ret;
> -- 
> 2.5.0
> 

		Amit