Re: [PATCH 3/5] wcn36xx: handle new hal response format

From: kbuild test robot <lkp@intel.com>
To: "Yin, Fengwei" <fengwei.yin@linaro.org>
Cc: kbuild-all@01.org, andy.green@linaro.org,
	linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
	me@bobcopeland.com, k.eugene.e@gmail.com,
	bjorn.andersson@sonymobile.com, fengwei.yin@linaro.org
Subject: Re: [PATCH 3/5] wcn36xx: handle new hal response format
Date: Mon, 9 Nov 2015 18:22:52 +0800	[thread overview]
Message-ID: <201511091809.c0vQX1oT%fengguang.wu@intel.com> (raw)
In-Reply-To: <1447063362-27322-4-git-send-email-fengwei.yin@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 3304 bytes --]

Hi Andy,

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on v4.3 next-20151109]

url:    https://github.com/0day-ci/linux/commits/Yin-Fengwei/wcn36xx-add-some-new-firmware-functionalities-support/20151109-170444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: x86_64-randconfig-s4-11091756 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from include/linux/skbuff.h:17,
                    from include/linux/if_ether.h:23,
                    from include/linux/etherdevice.h:25,
                    from drivers/net/wireless/ath/wcn36xx/smd.c:19:
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_rsp_status_check_v2':
   drivers/net/wireless/ath/wcn36xx/smd.c:310:27: error: 'WCN36XX_CHIP_3620' undeclared (first use in this function)
     if (wcn->chip_version != WCN36XX_CHIP_3620 ||
                              ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> drivers/net/wireless/ath/wcn36xx/smd.c:310:2: note: in expansion of macro 'if'
     if (wcn->chip_version != WCN36XX_CHIP_3620 ||
     ^
   drivers/net/wireless/ath/wcn36xx/smd.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
     if (wcn->chip_version != WCN36XX_CHIP_3620 ||
                              ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> drivers/net/wireless/ath/wcn36xx/smd.c:310:2: note: in expansion of macro 'if'
     if (wcn->chip_version != WCN36XX_CHIP_3620 ||
     ^
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
   drivers/net/wireless/ath/wcn36xx/smd.c:305:12: warning: 'wcn36xx_smd_rsp_status_check_v2' defined but not used [-Wunused-function]
    static int wcn36xx_smd_rsp_status_check_v2(struct wcn36xx *wcn, void *buf,
               ^

vim +/if +310 drivers/net/wireless/ath/wcn36xx/smd.c

   294			return -EIO;
   295	
   296		rsp = (struct wcn36xx_fw_msg_status_rsp *)
   297			(buf + sizeof(struct wcn36xx_hal_msg_header));
   298	
   299		if (WCN36XX_FW_MSG_RESULT_SUCCESS != rsp->status)
   300			return rsp->status;
   301	
   302		return 0;
   303	}
   304	
   305	static int wcn36xx_smd_rsp_status_check_v2(struct wcn36xx *wcn, void *buf,
   306						     size_t len)
   307	{
   308		struct wcn36xx_fw_msg_status_rsp_v2 *rsp;
   309	
 > 310		if (wcn->chip_version != WCN36XX_CHIP_3620 ||
   311		    len < sizeof(struct wcn36xx_hal_msg_header) + sizeof(*rsp))
   312			return wcn36xx_smd_rsp_status_check(buf, len);
   313	
   314		rsp = buf + sizeof(struct wcn36xx_hal_msg_header);
   315	
   316		if (WCN36XX_FW_MSG_RESULT_SUCCESS != rsp->status)
   317			return rsp->status;
   318	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 25396 bytes --]