From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw5Ui-00011c-6P for qemu-devel@nongnu.org; Tue, 10 Nov 2015 04:45:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zw5Ue-0002VH-Sh for qemu-devel@nongnu.org; Tue, 10 Nov 2015 04:45:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw5Ue-0002VA-Na for qemu-devel@nongnu.org; Tue, 10 Nov 2015 04:45:36 -0500 Date: Tue, 10 Nov 2015 09:45:34 +0000 From: Stefan Hajnoczi Message-ID: <20151110094534.GA14128@stefanha-x1.localdomain> References: <1446911700-16803-1-git-send-email-den@openvz.org> <20151109173742.GD29494@stefanha-x1.localdomain> <5640DE86.6020408@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Content-Disposition: inline In-Reply-To: <5640DE86.6020408@openvz.org> Subject: Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org, Juan Quintela --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 09, 2015 at 08:57:26PM +0300, Denis V. Lunev wrote: > On 11/09/2015 08:37 PM, Stefan Hajnoczi wrote: > >On Sat, Nov 07, 2015 at 06:54:50PM +0300, Denis V. Lunev wrote: > >>with test > >> while /bin/true ; do > >> virsh snapshot-create rhel7 > >> sleep 10 > >> virsh snapshot-delete rhel7 --current > >> done > >>with enabled iothreads on a running VM leads to a lot of troubles: hang= s, > >>asserts, errors. > >> > >>Anyway, I think that the construction like > >> assert(aio_context_is_locked(aio_context)); > >>should be widely used to ensure proper locking. > >> > >>Changes from v5: > >>- dropped already merged patch 11 > >>- fixed spelling in patch 1 > >>- changed order of condition in loops in all patches. Thank you Stefan = :) > >>- dropped patch 9 > >>- aio_context is not acquired any more in bdrv_all_find_vmstate_bs by r= equest > >> of Stefan > >>- patch 10 is implemented in completely different way > >I left comments on specific patches. Besides that, I'm happy. > OK. that sounds good enough to me. These changes > are not a problem at all. >=20 > Should we ask Juan that this is good for him? I think the requested changes won't be controversial. Sending the next revision should be fine. Stefan --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWQby9AAoJEJykq7OBq3PIfG4H/2uWAwg5IbZ9HDdq91UnZVLD Zp4614hWkfhgw3Yk04y6aAXQ5uoTL0CZUXNZ1pdCbEKQZM8z31a7fGHxcVCQMzbT IebECpjiUbjm5hLKjYanSTU9r64RbkaOsgx1wGBAJXRb8WXsyv8sDikIVhaLEx5r sV2EJmqYKBoMtpk7k9l2MdwOvMIyDWogkg//jq57oa/8yhI8A73DORVWutatxjbj GdZzouho4a7pm5kBBYLRQlyO2J1Os901cIRSOKh8vhdaZcP5BTmq/T7Dlig0kl84 OJa1v63W5eKGoj0d3tUInSp3IkH97NpO57RBWsxXd4+naeQcSPeIe5Cu9cp9SfM= =ix3/ -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5--