From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753635AbbKJPHR (ORCPT ); Tue, 10 Nov 2015 10:07:17 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38121 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbbKJPHP (ORCPT ); Tue, 10 Nov 2015 10:07:15 -0500 Date: Tue, 10 Nov 2015 17:07:13 +0200 From: "Kirill A. Shutemov" To: Borislav Petkov Cc: "Kirill A. Shutemov" , hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com, elliott@hpe.com, boris.ostrovsky@oracle.com, Toshi Kani Subject: Re: [PATCH] x86/mm: fix regression with huge pages on PAE Message-ID: <20151110150713.GA11956@node.shutemov.name> References: <1447111090-8526-1-git-send-email-kirill.shutemov@linux.intel.com> <20151110123429.GE19187@pd.tnic> <20151110135303.GA11246@node.shutemov.name> <20151110144648.GG19187@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151110144648.GG19187@pd.tnic> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2015 at 03:46:48PM +0100, Borislav Petkov wrote: > On Tue, Nov 10, 2015 at 03:53:03PM +0200, Kirill A. Shutemov wrote: > > Oh.. pmdval_t/pudval_t is 'unsinged long' on 64 bit. But realmode code > > uses -m16 which makes 'unsigned long' 32-bit therefore truncation warning. > > > > These helpers not really used in realmode code. > > Hrrm, yeah, that's just the nasty include hell causing it. The diff > below fixes it with my config but it'll probably need a more careful > analysis and reshuffling of includes/defines. > > Certainly better to do that than accomodating realmode to not throw > warnings with ifdeffery... Yeah. Looks good to me. > --- > diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h > index 0033e96c3f09..9011a88353de 100644 > --- a/arch/x86/boot/boot.h > +++ b/arch/x86/boot/boot.h > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > #include "bitops.h" > #include "ctype.h" > diff --git a/arch/x86/boot/video-mode.c b/arch/x86/boot/video-mode.c > index aa8a96b052e3..896077ed3381 100644 > --- a/arch/x86/boot/video-mode.c > +++ b/arch/x86/boot/video-mode.c > @@ -19,6 +19,9 @@ > #include "video.h" > #include "vesa.h" > > +#define NORMAL_VGA 0xffff /* 80x25 mode */ > +#define EXTENDED_VGA 0xfffe /* 80x50 mode */ > + > /* > * Common variables > */ > diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c > index 05111bb8d018..a839448038b6 100644 > --- a/arch/x86/boot/video.c > +++ b/arch/x86/boot/video.c > @@ -17,6 +17,8 @@ > #include "video.h" > #include "vesa.h" > > +#define ASK_VGA 0xfffd /* ask for it at bootup */ > + > static u16 video_segment; > > static void store_cursor_position(void) > diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h > index 48d34d28f5a6..cd0fc0cc78bc 100644 > --- a/arch/x86/include/asm/x86_init.h > +++ b/arch/x86/include/asm/x86_init.h > @@ -1,7 +1,6 @@ > #ifndef _ASM_X86_PLATFORM_H > #define _ASM_X86_PLATFORM_H > > -#include > #include > > struct mpc_bus; > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by kanga.kvack.org (Postfix) with ESMTP id C4FC16B0253 for ; Tue, 10 Nov 2015 10:07:16 -0500 (EST) Received: by wmdw130 with SMTP id w130so74972282wmd.0 for ; Tue, 10 Nov 2015 07:07:16 -0800 (PST) Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com. [2a00:1450:400c:c09::22a]) by mx.google.com with ESMTPS id db5si5014946wjb.82.2015.11.10.07.07.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 07:07:15 -0800 (PST) Received: by wmvv187 with SMTP id v187so12536001wmv.1 for ; Tue, 10 Nov 2015 07:07:14 -0800 (PST) Date: Tue, 10 Nov 2015 17:07:13 +0200 From: "Kirill A. Shutemov" Subject: Re: [PATCH] x86/mm: fix regression with huge pages on PAE Message-ID: <20151110150713.GA11956@node.shutemov.name> References: <1447111090-8526-1-git-send-email-kirill.shutemov@linux.intel.com> <20151110123429.GE19187@pd.tnic> <20151110135303.GA11246@node.shutemov.name> <20151110144648.GG19187@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151110144648.GG19187@pd.tnic> Sender: owner-linux-mm@kvack.org List-ID: To: Borislav Petkov Cc: "Kirill A. Shutemov" , hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com, elliott@hpe.com, boris.ostrovsky@oracle.com, Toshi Kani On Tue, Nov 10, 2015 at 03:46:48PM +0100, Borislav Petkov wrote: > On Tue, Nov 10, 2015 at 03:53:03PM +0200, Kirill A. Shutemov wrote: > > Oh.. pmdval_t/pudval_t is 'unsinged long' on 64 bit. But realmode code > > uses -m16 which makes 'unsigned long' 32-bit therefore truncation warning. > > > > These helpers not really used in realmode code. > > Hrrm, yeah, that's just the nasty include hell causing it. The diff > below fixes it with my config but it'll probably need a more careful > analysis and reshuffling of includes/defines. > > Certainly better to do that than accomodating realmode to not throw > warnings with ifdeffery... Yeah. Looks good to me. > --- > diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h > index 0033e96c3f09..9011a88353de 100644 > --- a/arch/x86/boot/boot.h > +++ b/arch/x86/boot/boot.h > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > #include "bitops.h" > #include "ctype.h" > diff --git a/arch/x86/boot/video-mode.c b/arch/x86/boot/video-mode.c > index aa8a96b052e3..896077ed3381 100644 > --- a/arch/x86/boot/video-mode.c > +++ b/arch/x86/boot/video-mode.c > @@ -19,6 +19,9 @@ > #include "video.h" > #include "vesa.h" > > +#define NORMAL_VGA 0xffff /* 80x25 mode */ > +#define EXTENDED_VGA 0xfffe /* 80x50 mode */ > + > /* > * Common variables > */ > diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c > index 05111bb8d018..a839448038b6 100644 > --- a/arch/x86/boot/video.c > +++ b/arch/x86/boot/video.c > @@ -17,6 +17,8 @@ > #include "video.h" > #include "vesa.h" > > +#define ASK_VGA 0xfffd /* ask for it at bootup */ > + > static u16 video_segment; > > static void store_cursor_position(void) > diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h > index 48d34d28f5a6..cd0fc0cc78bc 100644 > --- a/arch/x86/include/asm/x86_init.h > +++ b/arch/x86/include/asm/x86_init.h > @@ -1,7 +1,6 @@ > #ifndef _ASM_X86_PLATFORM_H > #define _ASM_X86_PLATFORM_H > > -#include > #include > > struct mpc_bus; > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org