From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40010)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZwCZt-0000nT-F1
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:19:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZwCZq-00020F-Rc
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:19:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45085)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZwCZq-0001ze-Ly
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:19:26 -0500
Date: Tue, 10 Nov 2015 12:19:23 -0500
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20151110171923.GH1600@localhost.localdomain>
References: <1447146556-7328-1-git-send-email-prasanna.kalever@redhat.com>
	<1447146556-7328-4-git-send-email-prasanna.kalever@redhat.com>
	<56421638.2050305@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56421638.2050305@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for
 multiple gluster servers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, pkrempa@redhat.com, Prasanna Kumar Kalever <prasanna.kalever@redhat.com>, stefanha@gmail.com, qemu-devel@nongnu.org, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com

On Tue, Nov 10, 2015 at 09:07:20AM -0700, Eric Blake wrote:
> On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote:
> > This patch adds a way to specify multiple volfile servers to the gluster
> > block backend of QEMU with tcp|rdma transport types and their port numbers.
> > 

[...]

> > +/*
> > +*
> > +*  Basic command line syntax looks like:
> > +*
> 
> You have 110 lines from /* to */.  In v10, I already mentioned that this
> comment is probably 100 lines too long.  You do NOT need to repeat the
> syntax, examples, or even more-readable example here; having them in the
> commit body was enough.  Someone that knows how to read qapi will be
> able to deduce what this function is doing if you were to simplify to
> just this:
> 
> /*
>  * Convert the command line into qapi.
>  */
> 

Maybe a good compromise could be moving this into docs/gluster.txt
(which doesn't exist, but could get its start this way!).  That way,
the info is there to read / find with grep without needing to look at
commit logs.


[...]


-Jeff