From: Andrea Arcangeli <aarcange@redhat.com>
To: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-mm@kvack.org, borntraeger@de.ibm.com
Subject: Re: [PATCH] mm: Loosen MADV_NOHUGEPAGE to enable Qemu postcopy on s390
Date: Wed, 11 Nov 2015 18:30:44 +0100 [thread overview]
Message-ID: <20151111173044.GF4573@redhat.com> (raw)
In-Reply-To: <1447256116-16461-1-git-send-email-jjherne@linux.vnet.ibm.com>
Hi Jason,
On Wed, Nov 11, 2015 at 10:35:16AM -0500, Jason J. Herne wrote:
> MADV_NOHUGEPAGE processing is too restrictive. kvm already disables
> hugepage but hugepage_madvise() takes the error path when we ask to turn
> on the MADV_NOHUGEPAGE bit and the bit is already on. This causes Qemu's
I wonder why KVM disables transparent hugepages on s390. It sounds
weird to disable transparent hugepages with KVM. In fact on x86 we
call MADV_HUGEPAGE to be sure transparent hugepages are enabled on the
guest physical memory, even if the transparent_hugepage/enabled ==
madvise.
> new postcopy migration feature to fail on s390 because its first action is
> to madvise the guest address space as NOHUGEPAGE. This patch modifies the
> code so that the operation succeeds without error now.
The other way is to change qemu to keep track it already called
MADV_NOHUGEPAGE and not to call it again. I don't have a strong
opinion on this, I think it's ok to return 0 but it's a visible change
to userland, I can't imagine it to break anything though. It sounds
very unlikely that an app could error out if it notices the kernel
doesn't error out on the second call of MADV_NOHUGEPAGE.
Glad to hear KVM postcopy live migration is already running on s390 too.
Thanks,
Andrea
>
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index c29ddeb..a8b5347 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2025,7 +2025,7 @@ int hugepage_madvise(struct vm_area_struct *vma,
> /*
> * Be somewhat over-protective like KSM for now!
> */
> - if (*vm_flags & (VM_NOHUGEPAGE | VM_NO_THP))
> + if (*vm_flags & VM_NO_THP)
> return -EINVAL;
> *vm_flags &= ~VM_HUGEPAGE;
> *vm_flags |= VM_NOHUGEPAGE;
> --
> 1.9.1
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-11 17:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 15:35 [PATCH] mm: Loosen MADV_NOHUGEPAGE to enable Qemu postcopy on s390 Jason J. Herne
2015-11-11 17:30 ` Andrea Arcangeli [this message]
2015-11-11 19:47 ` Christian Borntraeger
2015-11-11 19:47 ` Christian Borntraeger
2015-11-11 20:42 ` Andrea Arcangeli
2015-11-11 20:42 ` Andrea Arcangeli
2015-11-11 20:01 ` Christian Borntraeger
2015-11-11 20:37 ` Andrea Arcangeli
2015-11-11 20:37 ` Andrea Arcangeli
2015-11-12 15:18 Jason J. Herne
2015-11-12 16:45 ` Christian Borntraeger
2015-11-13 22:58 ` David Rientjes
[not found] ` <1447341516-18076-1-git-send-email-jjherne-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2015-11-18 13:31 ` Vlastimil Babka
2015-11-18 13:31 ` Vlastimil Babka
2015-11-19 8:22 ` Christian Borntraeger
[not found] ` <564D86AE.1010305-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2015-11-19 9:31 ` Vlastimil Babka
2015-11-19 9:31 ` Vlastimil Babka
2015-11-19 9:43 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111173044.GF4573@redhat.com \
--to=aarcange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.