* [PATCH] mm: change trace_mm_vmscan_writepage() proto type
@ 2015-11-12 7:42 ` yalin wang
0 siblings, 0 replies; 4+ messages in thread
From: yalin wang @ 2015-11-12 7:42 UTC (permalink / raw)
To: rostedt, mingo, namhyung, acme, yalin.wang2010, akpm, mhocko,
vdavydov, vbabka, hannes, mgorman, bywxiaobai, tj, linux-kernel,
linux-mm
Move trace_reclaim_flags() into trace function,
so that we don't need caculate these flags if the trace is disabled.
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
include/trace/events/vmscan.h | 7 +++----
mm/vmscan.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index f66476b..dae7836 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -330,10 +330,9 @@ DEFINE_EVENT(mm_vmscan_lru_isolate_template, mm_vmscan_memcg_isolate,
TRACE_EVENT(mm_vmscan_writepage,
- TP_PROTO(struct page *page,
- int reclaim_flags),
+ TP_PROTO(struct page *page),
- TP_ARGS(page, reclaim_flags),
+ TP_ARGS(page),
TP_STRUCT__entry(
__field(unsigned long, pfn)
@@ -342,7 +341,7 @@ TRACE_EVENT(mm_vmscan_writepage,
TP_fast_assign(
__entry->pfn = page_to_pfn(page);
- __entry->reclaim_flags = reclaim_flags;
+ __entry->reclaim_flags = trace_reclaim_flags(page);
),
TP_printk("page=%p pfn=%lu flags=%s",
diff --git a/mm/vmscan.c b/mm/vmscan.c
index a4507ec..83cea53 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -594,7 +594,7 @@ static pageout_t pageout(struct page *page, struct address_space *mapping,
/* synchronous write or broken a_ops? */
ClearPageReclaim(page);
}
- trace_mm_vmscan_writepage(page, trace_reclaim_flags(page));
+ trace_mm_vmscan_writepage(page);
inc_zone_page_state(page, NR_VMSCAN_WRITE);
return PAGE_SUCCESS;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mm: change trace_mm_vmscan_writepage() proto type
@ 2015-11-12 7:42 ` yalin wang
0 siblings, 0 replies; 4+ messages in thread
From: yalin wang @ 2015-11-12 7:42 UTC (permalink / raw)
To: rostedt, mingo, namhyung, acme, yalin.wang2010, akpm, mhocko,
vdavydov, vbabka, hannes, mgorman, bywxiaobai, tj, linux-kernel,
linux-mm
Move trace_reclaim_flags() into trace function,
so that we don't need caculate these flags if the trace is disabled.
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
include/trace/events/vmscan.h | 7 +++----
mm/vmscan.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index f66476b..dae7836 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -330,10 +330,9 @@ DEFINE_EVENT(mm_vmscan_lru_isolate_template, mm_vmscan_memcg_isolate,
TRACE_EVENT(mm_vmscan_writepage,
- TP_PROTO(struct page *page,
- int reclaim_flags),
+ TP_PROTO(struct page *page),
- TP_ARGS(page, reclaim_flags),
+ TP_ARGS(page),
TP_STRUCT__entry(
__field(unsigned long, pfn)
@@ -342,7 +341,7 @@ TRACE_EVENT(mm_vmscan_writepage,
TP_fast_assign(
__entry->pfn = page_to_pfn(page);
- __entry->reclaim_flags = reclaim_flags;
+ __entry->reclaim_flags = trace_reclaim_flags(page);
),
TP_printk("page=%p pfn=%lu flags=%s",
diff --git a/mm/vmscan.c b/mm/vmscan.c
index a4507ec..83cea53 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -594,7 +594,7 @@ static pageout_t pageout(struct page *page, struct address_space *mapping,
/* synchronous write or broken a_ops? */
ClearPageReclaim(page);
}
- trace_mm_vmscan_writepage(page, trace_reclaim_flags(page));
+ trace_mm_vmscan_writepage(page);
inc_zone_page_state(page, NR_VMSCAN_WRITE);
return PAGE_SUCCESS;
}
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: change trace_mm_vmscan_writepage() proto type
2015-11-12 7:42 ` yalin wang
@ 2015-11-12 14:24 ` Steven Rostedt
-1 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2015-11-12 14:24 UTC (permalink / raw)
To: yalin wang
Cc: mingo, namhyung, acme, akpm, mhocko, vdavydov, vbabka, hannes,
mgorman, bywxiaobai, tj, linux-kernel, linux-mm
On Thu, 12 Nov 2015 15:42:33 +0800
yalin wang <yalin.wang2010@gmail.com> wrote:
> Move trace_reclaim_flags() into trace function,
> so that we don't need caculate these flags if the trace is disabled.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: change trace_mm_vmscan_writepage() proto type
@ 2015-11-12 14:24 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2015-11-12 14:24 UTC (permalink / raw)
To: yalin wang
Cc: mingo, namhyung, acme, akpm, mhocko, vdavydov, vbabka, hannes,
mgorman, bywxiaobai, tj, linux-kernel, linux-mm
On Thu, 12 Nov 2015 15:42:33 +0800
yalin wang <yalin.wang2010@gmail.com> wrote:
> Move trace_reclaim_flags() into trace function,
> so that we don't need caculate these flags if the trace is disabled.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-12 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 7:42 [PATCH] mm: change trace_mm_vmscan_writepage() proto type yalin wang
2015-11-12 7:42 ` yalin wang
2015-11-12 14:24 ` Steven Rostedt
2015-11-12 14:24 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.