From: Bob Paauwe <bob.j.paauwe@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] igt/pm_rps: current freq < user specified min is no longer a fail
Date: Thu, 12 Nov 2015 10:17:38 -0800 [thread overview]
Message-ID: <20151112101738.4bdb3c17@bpaauwe-desk.fm.intel.com> (raw)
In-Reply-To: <1447319891.6396.3.camel@intel.com>
On Thu, 12 Nov 2015 11:18:11 +0200
Imre Deak <imre.deak@intel.com> wrote:
> On ke, 2015-11-11 at 13:37 -0800, Bob Paauwe wrote:
> > Since commit
> >
> > commit aed242ff7ebb697e4dff912bd4dc7ec7192f7581
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date: Wed Mar 18 09:48:21 2015 +0000
> >
> > drm/i915: Relax RPS contraints to allows setting minfreq on
> > idle
> >
> > it is now possible that the current frequency will drop below the
> > user
> > specified minimum frequency. Update the pm_rps tests to reflect that
> > this is no longer considered a failure.
>
> Yes, in case the GPU is idle the frequency will drop now to the idle fr
> equency regardless of the minimum limit set by the user. We should
> still check though if the frequency drops to the idle value not
> something higher. You can use the i915_frequency_info in debugfs for
> that.
>
Yeah, good idea.
Right now, the idle freq is the same as the hardware minimum. So I
could have it check against the hardware min. Adding support to read
the info out i915_frequency_info would be a larger change to the test.
But that might be a better long term solution.
> >
> > Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
> > ---
> > tests/pm_rps.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/tests/pm_rps.c b/tests/pm_rps.c
> > index 74f08f4..e92ca3b 100644
> > --- a/tests/pm_rps.c
> > +++ b/tests/pm_rps.c
> > @@ -146,7 +146,6 @@ static void checkit(const int *freqs)
> > {
> > igt_assert_lte(freqs[MIN], freqs[MAX]);
> > igt_assert_lte(freqs[CUR], freqs[MAX]);
> > - igt_assert_lte(freqs[MIN], freqs[CUR]);
> > igt_assert_lte(freqs[RPn], freqs[MIN]);
> > igt_assert_lte(freqs[MAX], freqs[RP0]);
> > igt_assert_lte(freqs[RP1], freqs[RP0]);
> > @@ -472,14 +471,14 @@ static void idle_check(void)
> > read_freqs(freqs);
> > dump(freqs);
> > checkit(freqs);
> > - if (freqs[CUR] == freqs[MIN])
> > + if (freqs[CUR] <= freqs[MIN])
> > break;
> > usleep(1000 * IDLE_WAIT_TIMESTEP_MSEC);
> > wait += IDLE_WAIT_TIMESTEP_MSEC;
> > } while (wait < IDLE_WAIT_TIMEOUT_MSEC);
> >
> > - igt_assert_eq(freqs[CUR], freqs[MIN]);
> > - igt_debug("Required %d msec to reach cur=min\n", wait);
> > + igt_assert_lte(freqs[CUR], freqs[MIN]);
> > + igt_debug("Required %d msec to reach cur<=min\n", wait);
> > }
> >
> > #define LOADED_WAIT_TIMESTEP_MSEC 100
--
--
Bob Paauwe
Bob.J.Paauwe@intel.com
IOTG / PED Software Organization
Intel Corp. Folsom, CA
(916) 356-6193
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-12 17:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 21:37 [PATCH i-g-t] igt/pm_rps: current freq < user specified min is no longer a fail Bob Paauwe
2015-11-12 9:18 ` Imre Deak
2015-11-12 18:17 ` Bob Paauwe [this message]
2015-11-30 11:30 ` Imre Deak
2015-12-01 0:23 ` [PATCH 0/2] igt/pm_rps: Handle freq < user min in specific cases Bob Paauwe
2015-12-01 0:23 ` [PATCH 1/2] igt/pm_rps: current freq < user specified min is not a fail (v2) Bob Paauwe
2015-12-01 13:51 ` Imre Deak
2015-12-04 0:28 ` [PATCH] igt/pm_rps: current freq < user specified min is not a fail (v3) Bob Paauwe
2015-12-04 14:34 ` Imre Deak
2015-12-01 0:23 ` [PATCH 2/2] igt/pm_rps: Add checks for freq = idle (RPn) in specific cases Bob Paauwe
2015-12-01 13:56 ` Imre Deak
2015-12-01 17:22 ` Bob Paauwe
2015-12-01 17:43 ` Imre Deak
2015-12-04 0:43 ` Bob Paauwe
2015-12-04 15:22 ` Imre Deak
2015-12-04 18:37 ` Bob Paauwe
2015-12-04 20:58 ` Imre Deak
2015-12-04 22:41 ` Bob Paauwe
2015-12-07 15:00 ` Imre Deak
2015-12-07 21:56 ` Bob Paauwe
2015-12-11 8:48 ` Kamble, Sagar A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112101738.4bdb3c17@bpaauwe-desk.fm.intel.com \
--to=bob.j.paauwe@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.