From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932448AbbKLQ1t (ORCPT ); Thu, 12 Nov 2015 11:27:49 -0500 Received: from smtprelay0087.hostedemail.com ([216.40.44.87]:38135 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754072AbbKLQ1s (ORCPT ); Thu, 12 Nov 2015 11:27:48 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3874:4250:4321:4605:5007:6119:6261:7875:7903:9707:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:14659:21080:21088:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: flock67_6074dc5625d34 X-Filterd-Recvd-Size: 2518 Date: Thu, 12 Nov 2015 11:27:41 -0500 From: Steven Rostedt To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Peter Zijlstra , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sched/rt: hide push_irq_work_func declaration Message-ID: <20151112112741.3cec9496@gandalf.local.home> In-Reply-To: <3828565.oKfGk7yNIT@wuerfel> References: <3810009.VdDTV0h1Qp@wuerfel> <3828565.oKfGk7yNIT@wuerfel> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2015 17:19:58 +0100 Arnd Bergmann wrote: > The push_irq_work_func() function is conditionally defined only > when both CONFIG_SMP and HAVE_RT_PUSH_IPI are defined, but the > forward declaration remains visibile without HAVE_RT_PUSH_IPI, > causing a gcc warning in ARM64 allnoconfig: > > kernel/sched/rt.c:68:13: warning: 'push_irq_work_func' declared 'static' but never defined [-Wunused-function] > > This changes the code to use the same condition for both the > declaration and the function definition, which gets rid of the > warning. > > As Peter Zijlstra, we can possibly get rid of the whole HAVE_RT_PUSH_IPI > thing after: > 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking") > > Until that is done, this patch can be used to avoid the warning. Acked-by: Steven Rostedt -- Steve > > Signed-off-by: Arnd Bergmann > Fixes: b6366f048e0c ("sched/rt: Use IPI to trigger RT task push migration instead of pulling") > --- > Found on arm64 allnoconfig > > v2: now using #if defined() instead IS_ENABLED() > > diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c > index e3cc16312046..ce7b36d6f477 100644 > --- a/kernel/sched/rt.c > +++ b/kernel/sched/rt.c > @@ -64,7 +64,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b) > raw_spin_unlock(&rt_b->rt_runtime_lock); > } > > -#ifdef CONFIG_SMP > +#if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > static void push_irq_work_func(struct irq_work *work); > #endif > From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Thu, 12 Nov 2015 11:27:41 -0500 Subject: [PATCH v2] sched/rt: hide push_irq_work_func declaration In-Reply-To: <3828565.oKfGk7yNIT@wuerfel> References: <3810009.VdDTV0h1Qp@wuerfel> <3828565.oKfGk7yNIT@wuerfel> Message-ID: <20151112112741.3cec9496@gandalf.local.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 12 Nov 2015 17:19:58 +0100 Arnd Bergmann wrote: > The push_irq_work_func() function is conditionally defined only > when both CONFIG_SMP and HAVE_RT_PUSH_IPI are defined, but the > forward declaration remains visibile without HAVE_RT_PUSH_IPI, > causing a gcc warning in ARM64 allnoconfig: > > kernel/sched/rt.c:68:13: warning: 'push_irq_work_func' declared 'static' but never defined [-Wunused-function] > > This changes the code to use the same condition for both the > declaration and the function definition, which gets rid of the > warning. > > As Peter Zijlstra, we can possibly get rid of the whole HAVE_RT_PUSH_IPI > thing after: > 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking") > > Until that is done, this patch can be used to avoid the warning. Acked-by: Steven Rostedt -- Steve > > Signed-off-by: Arnd Bergmann > Fixes: b6366f048e0c ("sched/rt: Use IPI to trigger RT task push migration instead of pulling") > --- > Found on arm64 allnoconfig > > v2: now using #if defined() instead IS_ENABLED() > > diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c > index e3cc16312046..ce7b36d6f477 100644 > --- a/kernel/sched/rt.c > +++ b/kernel/sched/rt.c > @@ -64,7 +64,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b) > raw_spin_unlock(&rt_b->rt_runtime_lock); > } > > -#ifdef CONFIG_SMP > +#if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > static void push_irq_work_func(struct irq_work *work); > #endif >