From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932370AbbKLLqa (ORCPT ); Thu, 12 Nov 2015 06:46:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34642 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932298AbbKLLq1 (ORCPT ); Thu, 12 Nov 2015 06:46:27 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 1/2] FS-Cache: Add missing initialization of ret in cachefiles_write_page() From: David Howells To: viro@ZenIV.linux.org.uk Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-cachefs@redhat.com, Geert Uytterhoeven , linux-fsdevel@vger.kernel.org Date: Thu, 12 Nov 2015 11:46:23 +0000 Message-ID: <20151112114623.22585.41976.stgit@warthog.procyon.org.uk> In-Reply-To: <20151112114614.22585.81355.stgit@warthog.procyon.org.uk> References: <20151112114614.22585.81355.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geert Uytterhoeven fs/cachefiles/rdwr.c: In function ‘cachefiles_write_page’: fs/cachefiles/rdwr.c:882: warning: ‘ret’ may be used uninitialized in this function If the jump to label "error" is taken, "ret" will indeed be uninitialized, and random stack data may be printed by the debug code. Fixes: 102f4d900c9c8f5e ("FS-Cache: Handle a write to the page immediately beyond the EOF marker") Signed-off-by: Geert Uytterhoeven Signed-off-by: David Howells --- fs/cachefiles/rdwr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index 7a6b02f72787..c0f3da3926a0 100644 --- a/fs/cachefiles/rdwr.c +++ b/fs/cachefiles/rdwr.c @@ -879,7 +879,7 @@ int cachefiles_write_page(struct fscache_storage *op, struct page *page) loff_t pos, eof; size_t len; void *data; - int ret; + int ret = -ENOBUFS; ASSERT(op != NULL); ASSERT(page != NULL); From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: [PATCH 1/2] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Date: Thu, 12 Nov 2015 11:46:23 +0000 Message-ID: <20151112114623.22585.41976.stgit@warthog.procyon.org.uk> References: <20151112114614.22585.81355.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com, Geert Uytterhoeven , linux-fsdevel@vger.kernel.org To: viro@ZenIV.linux.org.uk Return-path: In-Reply-To: <20151112114614.22585.81355.stgit@warthog.procyon.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cachefs-bounces@redhat.com Errors-To: linux-cachefs-bounces@redhat.com List-Id: linux-fsdevel.vger.kernel.org RnJvbTogR2VlcnQgVXl0dGVyaG9ldmVuIDxnZWVydEBsaW51eC1tNjhrLm9yZz4KCmZzL2NhY2hl ZmlsZXMvcmR3ci5jOiBJbiBmdW5jdGlvbiDigJhjYWNoZWZpbGVzX3dyaXRlX3BhZ2XigJk6CmZz L2NhY2hlZmlsZXMvcmR3ci5jOjg4Mjogd2FybmluZzog4oCYcmV04oCZIG1heSBiZSB1c2VkIHVu aW5pdGlhbGl6ZWQgaW4KdGhpcyBmdW5jdGlvbgoKSWYgdGhlIGp1bXAgdG8gbGFiZWwgImVycm9y IiBpcyB0YWtlbiwgInJldCIgd2lsbCBpbmRlZWQgYmUKdW5pbml0aWFsaXplZCwgYW5kIHJhbmRv bSBzdGFjayBkYXRhIG1heSBiZSBwcmludGVkIGJ5IHRoZSBkZWJ1ZyBjb2RlLgoKRml4ZXM6IDEw MmY0ZDkwMGM5YzhmNWUgKCJGUy1DYWNoZTogSGFuZGxlIGEgd3JpdGUgdG8gdGhlIHBhZ2UgaW1t ZWRpYXRlbHkgYmV5b25kIHRoZSBFT0YgbWFya2VyIikKU2lnbmVkLW9mZi1ieTogR2VlcnQgVXl0 dGVyaG9ldmVuIDxnZWVydEBsaW51eC1tNjhrLm9yZz4KU2lnbmVkLW9mZi1ieTogRGF2aWQgSG93 ZWxscyA8ZGhvd2VsbHNAcmVkaGF0LmNvbT4KLS0tCgogZnMvY2FjaGVmaWxlcy9yZHdyLmMgfCAg ICAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9mcy9jYWNoZWZpbGVzL3Jkd3IuYyBiL2ZzL2NhY2hlZmlsZXMvcmR3ci5jCmlu ZGV4IDdhNmIwMmY3Mjc4Ny4uYzBmM2RhMzkyNmEwIDEwMDY0NAotLS0gYS9mcy9jYWNoZWZpbGVz L3Jkd3IuYworKysgYi9mcy9jYWNoZWZpbGVzL3Jkd3IuYwpAQCAtODc5LDcgKzg3OSw3IEBAIGlu dCBjYWNoZWZpbGVzX3dyaXRlX3BhZ2Uoc3RydWN0IGZzY2FjaGVfc3RvcmFnZSAqb3AsIHN0cnVj dCBwYWdlICpwYWdlKQogCWxvZmZfdCBwb3MsIGVvZjsKIAlzaXplX3QgbGVuOwogCXZvaWQgKmRh dGE7Ci0JaW50IHJldDsKKwlpbnQgcmV0ID0gLUVOT0JVRlM7CiAKIAlBU1NFUlQob3AgIT0gTlVM TCk7CiAJQVNTRVJUKHBhZ2UgIT0gTlVMTCk7CgotLQpMaW51eC1jYWNoZWZzIG1haWxpbmcgbGlz dApMaW51eC1jYWNoZWZzQHJlZGhhdC5jb20KaHR0cHM6Ly93d3cucmVkaGF0LmNvbS9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWNhY2hlZnM=