From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754660AbbKLO6F (ORCPT ); Thu, 12 Nov 2015 09:58:05 -0500 Received: from foss.arm.com ([217.140.101.70]:36661 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbbKLO6E (ORCPT ); Thu, 12 Nov 2015 09:58:04 -0500 Date: Thu, 12 Nov 2015 14:57:59 +0000 From: Catalin Marinas To: Arnd Bergmann Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Suzuki K. Poulose" Subject: Re: [PATCH] ARM64: mark cpus_have_hwcap as __maybe_unused Message-ID: <20151112145759.GH5627@e104818-lin.cambridge.arm.com> References: <5369626.MJXv4CTaxt@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5369626.MJXv4CTaxt@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 03:20:16PM +0100, Arnd Bergmann wrote: > cpus_have_hwcap() is defined as a 'static' function an only used in > one place that is inside of an #ifdef, so we get a warning when > the only user is disabled: > > arch/arm64/kernel/cpufeature.c:699:13: warning: 'cpus_have_hwcap' defined but not used [-Wunused-function] > > This marks the function as __maybe_unused, so the compiler knows that > it can drop the function definition without warning about it. > > Signed-off-by: Arnd Bergmann > Fixes: 37b01d53ceef ("arm64/HWCAP: Use system wide safe values") > --- > Found on arm64 allnoconfig I applied this patch and the other two you just posted. Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Thu, 12 Nov 2015 14:57:59 +0000 Subject: [PATCH] ARM64: mark cpus_have_hwcap as __maybe_unused In-Reply-To: <5369626.MJXv4CTaxt@wuerfel> References: <5369626.MJXv4CTaxt@wuerfel> Message-ID: <20151112145759.GH5627@e104818-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 12, 2015 at 03:20:16PM +0100, Arnd Bergmann wrote: > cpus_have_hwcap() is defined as a 'static' function an only used in > one place that is inside of an #ifdef, so we get a warning when > the only user is disabled: > > arch/arm64/kernel/cpufeature.c:699:13: warning: 'cpus_have_hwcap' defined but not used [-Wunused-function] > > This marks the function as __maybe_unused, so the compiler knows that > it can drop the function definition without warning about it. > > Signed-off-by: Arnd Bergmann > Fixes: 37b01d53ceef ("arm64/HWCAP: Use system wide safe values") > --- > Found on arm64 allnoconfig I applied this patch and the other two you just posted. Thanks. -- Catalin