From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwtQU-0004jZ-CO for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:04:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwtQM-0006vU-Nr for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:04:38 -0500 Date: Thu, 12 Nov 2015 13:04:23 -0200 From: Eduardo Habkost Message-ID: <20151112150423.GJ4180@thinpad.lan.raisama.net> References: <1447278167-320-1-git-send-email-ehabkost@redhat.com> <20151112133747-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151112133747-mutt-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote: > > nseries doesn't use qemu_set_hw_version() and doesn't need the > > compatibility magic of qemu_hw_version(). Use QEMU_VERSION > > directly. > > > > Signed-off-by: Eduardo Habkost > > This looks very wrong. > We should be reducing the users of QEMU_VERSION, > not adding more. I would like to hear from the users and maintainers of the nseries machines, to judge this. I assume they don't need ABI compatibility betweeen QEMU versions, and maybe they want to know the QEMU version they are running. -- Eduardo