All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
	Matias Bj??rling <m@bjorling.me>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	axboe@fb.com
Subject: Re: [PATCH] null_blk: Register as a LightNVM device
Date: Thu, 12 Nov 2015 07:52:30 -0800	[thread overview]
Message-ID: <20151112155230.GA30642@infradead.org> (raw)
In-Reply-To: <5644B4F4.5090805@kernel.dk>

On Thu, Nov 12, 2015 at 08:49:08AM -0700, Jens Axboe wrote:
> But it still avoids duplicating the generics of it. Patch for null_blk:
> 
> 3 files changed, 168 insertions(+), 7 deletions (-)
> 
> vs a standalone of:
> 
> 3 files changed, 459 insertions(+)
> 
> It doesn't screw up null_blk, so I'd prefer just adding it as an on-the-side
> mode for that.

300 lines of boilerplate for just setting up a few request_queues seem
wrong, can you show the actual patch you measured?

  reply	other threads:[~2015-11-12 15:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 10:06 [PATCH] null_blk: Register as a LightNVM device Matias Bjørling
2015-11-11 21:27 ` Jens Axboe
2015-11-11 22:11   ` Jens Axboe
2015-11-12 11:30     ` Matias Bjørling
2015-11-12  8:53 ` Christoph Hellwig
2015-11-12 15:49   ` Jens Axboe
2015-11-12 15:52     ` Christoph Hellwig [this message]
2015-11-12 15:54       ` Jens Axboe
2015-11-12 15:58         ` Christoph Hellwig
2015-11-12 16:00           ` Jens Axboe
2015-11-12 18:29             ` Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151112155230.GA30642@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.