From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx6NR-0007KG-EO for qemu-devel@nongnu.org; Thu, 12 Nov 2015 23:54:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx6NM-00069H-ET for qemu-devel@nongnu.org; Thu, 12 Nov 2015 23:54:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx6NM-00069C-9I for qemu-devel@nongnu.org; Thu, 12 Nov 2015 23:54:16 -0500 Date: Thu, 12 Nov 2015 23:54:13 -0500 From: Jeff Cody Message-ID: <20151113045413.GM1600@localhost.localdomain> References: <1447146556-7328-1-git-send-email-prasanna.kalever@redhat.com> <1447146556-7328-4-git-send-email-prasanna.kalever@redhat.com> <56421638.2050305@redhat.com> <442468387.9450444.1447322642567.JavaMail.zimbra@redhat.com> <20151112162335.GA16646@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151112162335.GA16646@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever Cc: kwolf@redhat.com, peter.maydell@linaro.org, pkrempa@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com On Thu, Nov 12, 2015 at 11:23:35AM -0500, Jeff Cody wrote: > On Thu, Nov 12, 2015 at 05:04:02AM -0500, Prasanna Kumar Kalever wrote: > > On Tuesday, November 10, 2015 9:37:20 PM, Eric Blake wrote: > > > > > > On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to specify multiple volfile servers to the gluster > > > > block backend of QEMU with tcp|rdma transport types and their port numbers. > > > > > > > > > > [...] > > > > [...] > > > > > > > > Overall, I think we are probably on the right track for the QMP > > > interface; but since blockdev-add is NOT stable yet for 2.5, it won't > > > hurt to wait to get this in until 2.6, to make sure we have plenty of > > > time; and it would also be nice to make sure we get nbd, nfs, rbd, > > > sheepdog all supported in the same release; possibly by sharing common > > > types instead of introducing GlusterServer as a one-off type. > > > > We are hoping this to go in 2.5 which is really important for gluster > > hyper-convergence release (next Feb). > > > > Is there any possibility of getting exception for this patch ? > > > > Thanks, > > -Prasanna > > > > Today is the hard freeze for 2.5 for new features. As the v14 patches > hit the list today, I will review them, and if they look good I can > pull patches into my tree. > > Whether there is an exception is really up to Peter Maydell > (added him to the cc) - if all looks good with the patches, I could > send a pull request out later today with them, but that will be late > in the evening for Peter. > I wanted to give a follow-up - as Eric pointed out in his reviews, the API interface could be made better by using some QAPI features that are not currently in qemu (discriminated unions). So I won't issue a pull request for this for 2.5, and we'll pick it up for 2.6 once the interface issues can be worked out. -Jeff