From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754853AbbKMNz4 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Nov 2015 08:55:56 -0500
Received: from mx2.suse.de ([195.135.220.15]:52949 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754137AbbKMNzy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Nov 2015 08:55:54 -0500
Date: Fri, 13 Nov 2015 14:55:52 +0100
From: Petr Mladek <pmladek@suse.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Chris J Arges <chris.j.arges@canonical.com>, live-patching@vger.kernel.org,
        jeyu@redhat.com, Josh Poimboeuf <jpoimboe@redhat.com>,
        Seth Jennings <sjenning@redhat.com>, Jiri Kosina <jikos@kernel.org>,
        Vojtech Pavlik <vojtech@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4 v5] livepatch: Simplify code for relocated external
 symbols
Message-ID: <20151113135552.GV2599@pathway.suse.cz>
References: <1447259366-7055-1-git-send-email-chris.j.arges@canonical.com>
 <1447347595-30728-1-git-send-email-chris.j.arges@canonical.com>
 <1447347595-30728-3-git-send-email-chris.j.arges@canonical.com>
 <alpine.LNX.2.00.1511131119330.5093@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1511131119330.5093@pobox.suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri 2015-11-13 11:24:33, Miroslav Benes wrote:
> On Thu, 12 Nov 2015, Chris J Arges wrote:
> 
> > From: Petr Mladek <pmladek@suse.com>
> > 
> > The livepatch module might be linked from several .o files.
> > All symbols that need to be shared between these .o files
> > should be exported. This is a normal programming practice.
> > I do not see any reason to access static symbols between
> > these .o files.
> > 
> > This patch removes the search for the static symbols within
> > the livepatch module. It makes it easier to understand
> > the meaning of the external flag and klp_find_external_symbol()
> > function.
> > 
> > Signed-off-by: Petr Mladek <pmladek@suse.com>
> > Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
> 
> I'd remove this patch from the patch set, because
> 
> 1. Josh needs to confirm that it is possible for kpatch to live without 
> external or that we can modify it. This could postpone this patch set as a 
> whole.
> 
> 2. I think the issue is quite independent of the problem this patch set 
> solves.
> 
> 3. I can even imagine that we could get rid of 'external' in klp_func and 
> its special handling completely if kpatch allows.
> 
> So let's solve it separately. Does anyone have a different opinion?

I agree. Let's solve this separately and leave it out for now.

Best Regards,
Petr