All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] snmp: Remove duplicate OUTMCAST stat increment
@ 2015-11-16 18:09 Neil Horman
  2015-11-16 21:37 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Neil Horman @ 2015-11-16 18:09 UTC (permalink / raw)
  To: netdev; +Cc: Neil Horman, Claus Jensen, David Miller

the OUTMCAST stat is double incremented, getting bumped once in the mcast code
itself, and again in the common ip output path.  Remove the mcast bump, as its
not needed

Validated by the reporter, with good results

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Claus Jensen <claus.jensen@microsemi.com>
CC: Claus Jensen <claus.jensen@microsemi.com>
CC: David Miller <davem@davemloft.net>
---
 net/ipv6/mcast.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 124338a..5ee56d0 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -1651,7 +1651,6 @@ out:
 	if (!err) {
 		ICMP6MSGOUT_INC_STATS(net, idev, ICMPV6_MLD2_REPORT);
 		ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS);
-		IP6_UPD_PO_STATS(net, idev, IPSTATS_MIB_OUTMCAST, payload_len);
 	} else {
 		IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS);
 	}
@@ -2015,7 +2014,6 @@ out:
 	if (!err) {
 		ICMP6MSGOUT_INC_STATS(net, idev, type);
 		ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS);
-		IP6_UPD_PO_STATS(net, idev, IPSTATS_MIB_OUTMCAST, full_len);
 	} else
 		IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS);
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] snmp: Remove duplicate OUTMCAST stat increment
  2015-11-16 18:09 [PATCH] snmp: Remove duplicate OUTMCAST stat increment Neil Horman
@ 2015-11-16 21:37 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-11-16 21:37 UTC (permalink / raw)
  To: nhorman; +Cc: netdev, claus.jensen

From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 16 Nov 2015 13:09:10 -0500

> the OUTMCAST stat is double incremented, getting bumped once in the mcast code
> itself, and again in the common ip output path.  Remove the mcast bump, as its
> not needed
> 
> Validated by the reporter, with good results
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: Claus Jensen <claus.jensen@microsemi.com>

Applied and queued up for -stable, thanks Neil.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-16 21:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-16 18:09 [PATCH] snmp: Remove duplicate OUTMCAST stat increment Neil Horman
2015-11-16 21:37 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.