From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyG9W-0008Ee-FL for qemu-devel@nongnu.org; Mon, 16 Nov 2015 04:32:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyG9T-0005kw-9I for qemu-devel@nongnu.org; Mon, 16 Nov 2015 04:32:46 -0500 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:36233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyG9T-0005ks-3a for qemu-devel@nongnu.org; Mon, 16 Nov 2015 04:32:43 -0500 Received: by pacdm15 with SMTP id dm15so169842798pac.3 for ; Mon, 16 Nov 2015 01:32:42 -0800 (PST) Date: Mon, 16 Nov 2015 17:32:39 +0800 From: Stefan Hajnoczi Message-ID: <20151116093239.GB16152@stefanha-x1.localdomain> References: <1447165535-31263-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TRYliJ5NKNqkz5bu" Content-Disposition: inline In-Reply-To: <1447165535-31263-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH for 2.5 v7 0/10] dataplane snapshot fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela --TRYliJ5NKNqkz5bu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 10, 2015 at 05:25:25PM +0300, Denis V. Lunev wrote: > with test > while /bin/true ; do > virsh snapshot-create rhel7 > sleep 10 > virsh snapshot-delete rhel7 --current > done > with enabled iothreads on a running VM leads to a lot of troubles: hangs, > asserts, errors. >=20 > Anyway, I think that the construction like > assert(aio_context_is_locked(aio_context)); > should be widely used to ensure proper locking. >=20 > Changes from v6: > - tricky part dropped from patch 7 > - patch 5 reworked to process snapshot list differently in info commands > and on savevm >=20 > Changes from v5: > - dropped already merged patch 11 > - fixed spelling in patch 1 > - changed order of condition in loops in all patches. Thank you Stefan > - dropped patch 9 > - aio_context is not acquired any more in bdrv_all_find_vmstate_bs by req= uest > of Stefan > - patch 10 is implemented in completely different way >=20 > Changes from v4: > - only migration/savevm.c code and monitor is affected now. Generic block > layer stuff will be sent separately to speedup merging. The approach > in general was negotiated with Juan and Stefan. >=20 > Changes from v3: > - more places found > - new aio_poll concept, see patch 10 >=20 > Changes from v2: > - droppped patch 5 as already merged > - changed locking scheme in patch 4 by suggestion of Juan >=20 > Changes from v1: > - aio-context locking added > - comment is rewritten >=20 > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Juan Quintela > CC: Kevin Wolf >=20 > Denis V. Lunev (10): > snapshot: create helper to test that block drivers supports snapshots > snapshot: return error code from bdrv_snapshot_delete_by_id_or_name > snapshot: create bdrv_all_delete_snapshot helper > snapshot: create bdrv_all_goto_snapshot helper > snapshot: create bdrv_all_find_snapshot helper > migration: drop find_vmstate_bs check in hmp_delvm > snapshot: create bdrv_all_create_snapshot helper > migration: reorder processing in hmp_savevm > migration: implement bdrv_all_find_vmstate_bs helper > migration: normalize locking in migration/savevm.c >=20 > block/snapshot.c | 135 ++++++++++++++++++++++++++++++- > include/block/snapshot.h | 25 +++++- > migration/savevm.c | 207 +++++++++++++++--------------------------= ------ > 3 files changed, 217 insertions(+), 150 deletions(-) All patches except Patch 6: Reviewed-by: Stefan Hajnoczi --TRYliJ5NKNqkz5bu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWSaK3AAoJEJykq7OBq3PIEPIH/iyIggAkNqR4eBjeUrgH8SJK eqk/+DtnEuv3/ISo9yFql8J8H4fjhqIMGGzn8NAVSu9NO+5Buq9SM5NMBP14G/a2 hlaonaZps3zgd1aLdQMvpNOqISo6EXQaa25MaxRJEG5qBBNy5QIC22+STpU5GeFg tRy4NwLI6kH+nOSpfkmeCuV5X0e/IyH8PDwMJOLLiiKgeNpAJhBgq3mZFWt6HvKp z3BcJFQHz/1kDJeElo7NH08/rrKNnbu5sd2v5ewYbzGq+7VrfearD/WuV96xyemm KC5V3pm76SOhyliSKBThqejjcGJ+YKYxfU8SafC2nL17QTO4AeT7Ue6LxF4P+ks= =owQI -----END PGP SIGNATURE----- --TRYliJ5NKNqkz5bu--