From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 16 Nov 2015 08:34:45 -0500 Subject: [U-Boot] [PATCH 10/17] powerpc/km8321: set the DDRCDR impedance settings back to half strength In-Reply-To: <5649CB8D.50808@keymile.com> References: <1447426768-23226-1-git-send-email-valentin.longchamp@keymile.com> <1447426768-23226-11-git-send-email-valentin.longchamp@keymile.com> <5649CB8D.50808@keymile.com> Message-ID: <20151116133445.GZ8060@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Nov 16, 2015 at 01:26:53PM +0100, Holger Brunck wrote: > Hi Valentin, > > On 13/11/15 15:59, Valentin Longchamp wrote: > > The impedance settings have been changed with commit > > 2ea8ae99595ca11dd228726e854ebc6268208601 (whose goal was to set > > the internal voltage level to the DDR2 value - and not DDR1). > > > > you are referencing the previous patch 09/17 here, shouldn't these two then not > be squashed? It's bad form to reference commit IDs of previous parts of a series as they will not match what happens when commited to the tree so please say the commit subject instead. And as Holger suggests, if this reference patch 9/17 here, just squash the two together and v2 just that patch please (assuming no further feedback on the series), thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: