From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753167AbbKPQwM (ORCPT ); Mon, 16 Nov 2015 11:52:12 -0500 Received: from foss.arm.com ([217.140.101.70]:51236 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbbKPQwI (ORCPT ); Mon, 16 Nov 2015 11:52:08 -0500 Date: Mon, 16 Nov 2015 16:52:06 +0000 From: Liviu Dudau To: Russell King - ARM Linux Cc: Mark Yao , Heiko Stuebner , Philipp Zabel , Daniel Vetter , David Airlie , Eric Anholt , linux-rockchip , LAKML , dri-devel , LKML Subject: Re: [PATCH 2/2] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() Message-ID: <20151116165206.GC4158@e106497-lin.cambridge.arm.com> References: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> <1447685093-26129-3-git-send-email-Liviu.Dudau@arm.com> <20151116163016.GO8644@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151116163016.GO8644@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2015 at 04:30:16PM +0000, Russell King - ARM Linux wrote: > I've tweaked your patch to make the above (buggy) change a little clearer. > > On Mon, Nov 16, 2015 at 02:44:53PM +0000, Liviu Dudau wrote: > > - for (i = 0;; i++) { > > - port = of_parse_phandle(np, "ports", i); > > - if (!port) > > - break; > > - > > - if (!of_device_is_available(port->parent)) { > > - of_node_put(port); > > - continue; > > - } > > > > - component_match_add(dev, &match, compare_of, port->parent); > > - of_node_put(port); > > - } > > > -static int compare_of(struct device *dev, void *data) > > -{ > > - struct device_node *np = data; > > - > > - return dev->of_node == np; > > -} > > The original above passes port->parent to component_match_add(). This > means 'np' in the above compare_of() function is 'port->parent'. > > This means the above comparison is effectively: > > dev->of_node == port->parent > > The generic code instead does this: > > component_match_add(dev, &match, compare_of, port); > > So what we get in the comparison function is 'port' rather than > 'port->parent': > > > +static int compare_port(struct device *dev, void *data) > > { > > + struct device_node *np = data; > > + return dev->parent->of_node == np; > > +} > > which means the comparison is: > > dev->parent->of_node == port > > which is a different comparison from the above. > > You instead want this to be: > > return dev->of_node == np->parent; > > Heiko, please test the above change to compare_port() - I think you'll > find that will fix your issue. Sorry, I admit I'm not very good at doing patches without being able to test them. :( Thanks for helping on this! Liviu > > Thanks. > > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH 2/2] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() Date: Mon, 16 Nov 2015 16:52:06 +0000 Message-ID: <20151116165206.GC4158@e106497-lin.cambridge.arm.com> References: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> <1447685093-26129-3-git-send-email-Liviu.Dudau@arm.com> <20151116163016.GO8644@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20151116163016.GO8644@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: linux-rockchip , Daniel Vetter , LKML , dri-devel , LAKML List-Id: linux-rockchip.vger.kernel.org T24gTW9uLCBOb3YgMTYsIDIwMTUgYXQgMDQ6MzA6MTZQTSArMDAwMCwgUnVzc2VsbCBLaW5nIC0g QVJNIExpbnV4IHdyb3RlOgo+IEkndmUgdHdlYWtlZCB5b3VyIHBhdGNoIHRvIG1ha2UgdGhlIGFi b3ZlIChidWdneSkgY2hhbmdlIGEgbGl0dGxlIGNsZWFyZXIuCj4gCj4gT24gTW9uLCBOb3YgMTYs IDIwMTUgYXQgMDI6NDQ6NTNQTSArMDAwMCwgTGl2aXUgRHVkYXUgd3JvdGU6Cj4gPiAtCWZvciAo aSA9IDA7OyBpKyspIHsKPiA+IC0JCXBvcnQgPSBvZl9wYXJzZV9waGFuZGxlKG5wLCAicG9ydHMi LCBpKTsKPiA+IC0JCWlmICghcG9ydCkKPiA+IC0JCQlicmVhazsKPiA+IC0KPiA+IC0JCWlmICgh b2ZfZGV2aWNlX2lzX2F2YWlsYWJsZShwb3J0LT5wYXJlbnQpKSB7Cj4gPiAtCQkJb2Zfbm9kZV9w dXQocG9ydCk7Cj4gPiAtCQkJY29udGludWU7Cj4gPiAtCQl9Cj4gPiAgCj4gPiAtCQljb21wb25l bnRfbWF0Y2hfYWRkKGRldiwgJm1hdGNoLCBjb21wYXJlX29mLCBwb3J0LT5wYXJlbnQpOwo+ID4g LQkJb2Zfbm9kZV9wdXQocG9ydCk7Cj4gPiAtCX0KPiAKPiA+IC1zdGF0aWMgaW50IGNvbXBhcmVf b2Yoc3RydWN0IGRldmljZSAqZGV2LCB2b2lkICpkYXRhKQo+ID4gLXsKPiA+IC0Jc3RydWN0IGRl dmljZV9ub2RlICpucCA9IGRhdGE7Cj4gPiAtCj4gPiAtCXJldHVybiBkZXYtPm9mX25vZGUgPT0g bnA7Cj4gPiAtfQo+IAo+IFRoZSBvcmlnaW5hbCBhYm92ZSBwYXNzZXMgcG9ydC0+cGFyZW50IHRv IGNvbXBvbmVudF9tYXRjaF9hZGQoKS4gIFRoaXMKPiBtZWFucyAnbnAnIGluIHRoZSBhYm92ZSBj b21wYXJlX29mKCkgZnVuY3Rpb24gaXMgJ3BvcnQtPnBhcmVudCcuCj4gCj4gVGhpcyBtZWFucyB0 aGUgYWJvdmUgY29tcGFyaXNvbiBpcyBlZmZlY3RpdmVseToKPiAKPiAJZGV2LT5vZl9ub2RlID09 IHBvcnQtPnBhcmVudAo+IAo+IFRoZSBnZW5lcmljIGNvZGUgaW5zdGVhZCBkb2VzIHRoaXM6Cj4g Cj4gICAgICAgICAgICAgICAgIGNvbXBvbmVudF9tYXRjaF9hZGQoZGV2LCAmbWF0Y2gsIGNvbXBh cmVfb2YsIHBvcnQpOwo+IAo+IFNvIHdoYXQgd2UgZ2V0IGluIHRoZSBjb21wYXJpc29uIGZ1bmN0 aW9uIGlzICdwb3J0JyByYXRoZXIgdGhhbgo+ICdwb3J0LT5wYXJlbnQnOgo+IAo+ID4gK3N0YXRp YyBpbnQgY29tcGFyZV9wb3J0KHN0cnVjdCBkZXZpY2UgKmRldiwgdm9pZCAqZGF0YSkKPiA+ICB7 Cj4gPiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAgPSBkYXRhOwo+ID4gKwlyZXR1cm4gZGV2LT5w YXJlbnQtPm9mX25vZGUgPT0gbnA7Cj4gPiArfQo+IAo+IHdoaWNoIG1lYW5zIHRoZSBjb21wYXJp c29uIGlzOgo+IAo+IAlkZXYtPnBhcmVudC0+b2Zfbm9kZSA9PSBwb3J0Cj4gCj4gd2hpY2ggaXMg YSBkaWZmZXJlbnQgY29tcGFyaXNvbiBmcm9tIHRoZSBhYm92ZS4KPiAKPiBZb3UgaW5zdGVhZCB3 YW50IHRoaXMgdG8gYmU6Cj4gCj4gCXJldHVybiBkZXYtPm9mX25vZGUgPT0gbnAtPnBhcmVudDsK PiAKPiBIZWlrbywgcGxlYXNlIHRlc3QgdGhlIGFib3ZlIGNoYW5nZSB0byBjb21wYXJlX3BvcnQo KSAtIEkgdGhpbmsgeW91J2xsCj4gZmluZCB0aGF0IHdpbGwgZml4IHlvdXIgaXNzdWUuCgpTb3Jy eSwgSSBhZG1pdCBJJ20gbm90IHZlcnkgZ29vZCBhdCBkb2luZyBwYXRjaGVzIHdpdGhvdXQgYmVp bmcgYWJsZQp0byB0ZXN0IHRoZW0uIDooCgpUaGFua3MgZm9yIGhlbHBpbmcgb24gdGhpcyEKCkxp dml1Cgo+IAo+IFRoYW5rcy4KPiAKPiAtLSAKPiBGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBs aW5lOiBjdXJyZW50bHkgYXQgOS42TWJwcyBkb3duIDQwMGticHMgdXAKPiBhY2NvcmRpbmcgdG8g c3BlZWR0ZXN0Lm5ldC4KPiAKCi0tIAo9PT09PT09PT09PT09PT09PT09PQp8IEkgd291bGQgbGlr ZSB0byB8CnwgZml4IHRoZSB3b3JsZCwgIHwKfCBidXQgdGhleSdyZSBub3QgfAp8IGdpdmluZyBt ZSB0aGUgICB8CiBcIHNvdXJjZSBjb2RlISAgLwogIC0tLS0tLS0tLS0tLS0tLQogICAgwq9cXyjj g4QpXy/CrwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu.Dudau@arm.com (Liviu Dudau) Date: Mon, 16 Nov 2015 16:52:06 +0000 Subject: [PATCH 2/2] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() In-Reply-To: <20151116163016.GO8644@n2100.arm.linux.org.uk> References: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> <1447685093-26129-3-git-send-email-Liviu.Dudau@arm.com> <20151116163016.GO8644@n2100.arm.linux.org.uk> Message-ID: <20151116165206.GC4158@e106497-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 16, 2015 at 04:30:16PM +0000, Russell King - ARM Linux wrote: > I've tweaked your patch to make the above (buggy) change a little clearer. > > On Mon, Nov 16, 2015 at 02:44:53PM +0000, Liviu Dudau wrote: > > - for (i = 0;; i++) { > > - port = of_parse_phandle(np, "ports", i); > > - if (!port) > > - break; > > - > > - if (!of_device_is_available(port->parent)) { > > - of_node_put(port); > > - continue; > > - } > > > > - component_match_add(dev, &match, compare_of, port->parent); > > - of_node_put(port); > > - } > > > -static int compare_of(struct device *dev, void *data) > > -{ > > - struct device_node *np = data; > > - > > - return dev->of_node == np; > > -} > > The original above passes port->parent to component_match_add(). This > means 'np' in the above compare_of() function is 'port->parent'. > > This means the above comparison is effectively: > > dev->of_node == port->parent > > The generic code instead does this: > > component_match_add(dev, &match, compare_of, port); > > So what we get in the comparison function is 'port' rather than > 'port->parent': > > > +static int compare_port(struct device *dev, void *data) > > { > > + struct device_node *np = data; > > + return dev->parent->of_node == np; > > +} > > which means the comparison is: > > dev->parent->of_node == port > > which is a different comparison from the above. > > You instead want this to be: > > return dev->of_node == np->parent; > > Heiko, please test the above change to compare_port() - I think you'll > find that will fix your issue. Sorry, I admit I'm not very good at doing patches without being able to test them. :( Thanks for helping on this! Liviu > > Thanks. > > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ?\_(?)_/?