From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Serialise updates to GGTT with access through GGTT on Braswell Date: Tue, 17 Nov 2015 17:37:02 +0100 Message-ID: <20151117163702.GL16848@phenom.ffwll.local> References: <1445622212-32604-1-git-send-email-chris@chris-wilson.co.uk> <1445622212-32604-2-git-send-email-chris@chris-wilson.co.uk> <20151030161421.GN16848@phenom.ffwll.local> <20151030165841.GC2014@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AE656E437 for ; Tue, 17 Nov 2015 08:37:07 -0800 (PST) Received: by wmww144 with SMTP id w144so34042528wmw.0 for ; Tue, 17 Nov 2015 08:37:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151030165841.GC2014@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMzAsIDIwMTUgYXQgMDQ6NTg6NDFQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIEZyaSwgT2N0IDMwLCAyMDE1IGF0IDA1OjE0OjIxUE0gKzAxMDAsIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBPbiBGcmksIE9jdCAyMywgMjAxNSBhdCAwNjo0MzozMlBNICswMTAw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+IFdoZW4gYWNjZXNzaW5nIHRocm91Z2ggdGhlIEdU VCBmcm9tIG9uZSBDUFUgd2hpbHN0IGNvbmN1cnJlbnRseSB1cGRhdGluZwo+ID4gPiB0aGUgR0dU VCBQVEVzIGluIGFub3RoZXIgdGhyZWFkLCB0aGUgaGFyZHdhcmUgbGlrZXMgdG8gcmV0dXJuIHJh bmRvbQo+ID4gPiBkYXRhLiBBcyB3ZSBoYXZlIHN0cm9uZyBzZXJpYWxpc2F0aW9uIHByZXZlbnQg dXMgZnJvbSBtb2RpZnlpbmcgdGhlIFBURQo+ID4gPiBvZiBhbiBhY3RpdmUgR1RUIG1tYXBwaW5n LCB3ZSBoYXZlIHRvIGNvbmNsdWRlIHRoYXQgaXQgd2hpbHN0IG1vZGlmeWluZwo+ID4gPiBvdGhl ciBQVEUncyB0aGF0IGVycm9yIG9jY3Vycy4gKEkgaGF2ZSBub3QgbG9va2VkIGZvciBhbnkgcGF0 dGVybiBzdWNoCj4gPiA+IGFzIG1vZGlmeWluZyBQVEUgd2l0aGluIHRoZSBzYW1lIHBhZ2Ugb3Ig Y2FjaGVsaW5lIGFzIGFjdGl2ZSBQVEUgLQo+ID4gPiB0aG91Z2ggY2hlY2tpbmcgd2hldGhlciBy ZXZva2luZyBuZWlnaGJvdXJpbmcgb2JqZWN0cyBzaG91bGQgYmUgZW5vdWdoCj4gPiA+IHRvIHRl c3QgdGhhdCB0aGVvcnkuKSBUaGUgY29ycnVwdGlvbiBhbHNvIHNlZW1zIHJlc3RyaWN0ZWQgdG8g QnJhc3dlbGwKPiA+ID4gYW5kIGRpc2FwcGVhcnMgd2l0aCBtYXhjcHVzPTAuIFRoaXMgcGF0Y2gg c3RvcHMgYWxsIGFjY2VzcyB0aHJvdWdoIHRoZQo+ID4gPiBHVFQgYnkgb3RoZXIgQ1BVcyB3aGVu IHdlIHVwZGF0ZSBhbnkgUFRFIGJ5IHN0b3BwaW5nIHRoZSBtYWNoaW5lIGFyb3VuZAo+ID4gPiB0 aGUgR0dUVCB1cGRhdGUuCj4gPiA+IAo+ID4gPiBUZXN0Y2FzZTogaWd0L2dlbV9jb25jdXJyZW50 X2JsaXQKPiA+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19i dWcuY2dpP2lkPTg5MDc5Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gCj4gPiBXaWxkIGd1ZXNzLCBzaW5jZSBpdCB3b3VsZG4n dCBiZSB0aGUgZmlyc3QgdGltZSBodyBlbmdpbmVlcnMgc2NyZXdlZCB0aGlzCj4gPiB1cC4KPiA+ IAo+ID4gQ2hlZXJzLCBEYW5pZWwKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0 LmMKPiA+IGluZGV4IGQxYzVjZjg5ZmU3Ny4uZGU5ODNjOGU2ZTU0IDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gPiBAQCAtMjMzNywxMiArMjMzNyw4IEBAIGludCBp OTE1X2dlbV9ndHRfcHJlcGFyZV9vYmplY3Qoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9i aikKPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBnZW44X3NldF9wdGUodm9pZCBfX2lvbWVtICphZGRy LCBnZW44X3B0ZV90IHB0ZSkKPiA+ICB7Cj4gPiAtI2lmZGVmIHdyaXRlcQo+ID4gLQl3cml0ZXEo cHRlLCBhZGRyKTsKPiA+IC0jZWxzZQo+ID4gIAlpb3dyaXRlMzIoKHUzMilwdGUsIGFkZHIpOwo+ ID4gIAlpb3dyaXRlMzIocHRlID4+IDMyLCBhZGRyICsgNCk7Cj4gPiAtI2VuZGlmCj4gCj4gVHJp ZWQ6Cj4gIHN0YXRpYyB2b2lkIGdlbjhfc2V0X3B0ZSh2b2lkIF9faW9tZW0gKmFkZHIsIGdlbjhf cHRlX3QgcHRlKQo+ICAgewo+ICAgLSNpZmRlZiB3cml0ZXEKPiAgIC0gICAgICAgd3JpdGVxKHB0 ZSwgYWRkcik7Cj4gICAtI2Vsc2UKPiAgIC0gICAgICAgaW93cml0ZTMyKCh1MzIpcHRlLCBhZGRy KTsKPiAgIC0gICAgICAgaW93cml0ZTMyKHB0ZSA+PiAzMiwgYWRkciArIDQpOwo+ICAgLSNlbmRp Zgo+ICAgKyAgICAgICBpb3dyaXRlMzIoMCwgYWRkcik7Cj4gICArICAgICAgIHdtYigpOwo+ICAg KyAgICAgICBpb3dyaXRlMzIodXBwZXJfMzJfYml0cyhwdGUpLCBhZGRyICsgNCk7Cj4gICArICAg ICAgIGlvd3JpdGUzMihsb3dlcl8zMl9iaXRzKHB0ZSksIGFkZHIpOwo+ICAgKyAgICAgICB3bWIo KTsKPiAgICB9Cj4gICAgIAo+IGFuZCBqdXN0IHRoZSBwbGFpbiBpb3dyaXRlKGxvd2VyKSwgaW93 cml0ZSh1cHBlciksIG5laXRoZXIgaGVscHMuCgpBZGRlZCBhIG5vdGUgYWJvdXQgdGhpcyBhbmQg YXBwbGllZCB0byBkaW5xLiBZYXkgZm9yIGF3ZXNvbWUgaHcuCgpUaGFua3MsIERhbmllbAotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK