From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbbKQSGS (ORCPT ); Tue, 17 Nov 2015 13:06:18 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:56675 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754434AbbKQSGN (ORCPT ); Tue, 17 Nov 2015 13:06:13 -0500 Date: Tue, 17 Nov 2015 19:05:32 +0100 From: Peter Zijlstra To: Oleg Nesterov Cc: Ingo Molnar , Milos Vyletel , Prarit Bhargava , Tejun Heo , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/8] stop_machine: make cpu_stop_queue_work() and stop_one_cpu_nowait() return bool Message-ID: <20151117180532.GB3816@twins.programming.kicks-ass.net> References: <20151115193254.GA8225@redhat.com> <20151115193317.GA8252@redhat.com> <20151117170523.GA13955@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151117170523.GA13955@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2015 at 06:05:23PM +0100, Oleg Nesterov wrote: > On 11/15, Oleg Nesterov wrote: > > > > --- a/include/linux/stop_machine.h > > +++ b/include/linux/stop_machine.h > > @@ -29,7 +29,7 @@ struct cpu_stop_work { > > > > int stop_one_cpu(unsigned int cpu, cpu_stop_fn_t fn, void *arg); > > int stop_two_cpus(unsigned int cpu1, unsigned int cpu2, cpu_stop_fn_t fn, void *arg); > > -void stop_one_cpu_nowait(unsigned int cpu, cpu_stop_fn_t fn, void *arg, > > +bool stop_one_cpu_nowait(unsigned int cpu, cpu_stop_fn_t fn, void *arg, > > struct cpu_stop_work *work_buf); > > Peter, sorry!!! > > I forgot to update the !CONFIG_SMP version of stop_one_cpu_nowait(). Please > see V2 below. No problem, updated the patch.