From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller Date: Tue, 17 Nov 2015 10:21:33 -0800 Message-ID: <20151117182133.GD29423@dtor-ws> References: <1447675269-8831-1-git-send-email-mpa@pengutronix.de> <1447675269-8831-4-git-send-email-mpa@pengutronix.de> <20151116141609.GA6167@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151116141609.GA6167@rob-hp-laptop> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Markus Pargmann , Shawn Guo , Jonathan Cameron , Lee Jones , Denis Carikli , Eric =?iso-8859-1?Q?B=E9nard?= , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Hartmut Knaack , Fabio Estevam List-Id: devicetree@vger.kernel.org On Mon, Nov 16, 2015 at 08:16:09AM -0600, Rob Herring wrote: > On Mon, Nov 16, 2015 at 01:01:04PM +0100, Markus Pargmann wrote: > > This is the touchscreen conversion queue binding documentation. It uses > > the shared imx25 ADC. > > > > Signed-off-by: Markus Pargmann > > --- > > > > Notes: > > Changes in v5: > > - Fix signed/unsigned comparison > > - Fix unused variable settling_time by putting it in the correct argument list > > - Use continous conversion queue with the repeat feature and a proper > > repeat-wait. Previously the touchscreen caused massive number of interrupts. > > > > .../bindings/input/touchscreen/fsl-mx25-tcq.txt | 29 ++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt b/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > new file mode 100644 > > index 000000000000..89ab47a3acc1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > @@ -0,0 +1,29 @@ > > +Freescale mx25 TS conversion queue module > > + > > +mx25 touchscreen conversion queue module which controls the ADC unit of the > > +mx25 for attached touchscreens. > > + > > +Required properties: > > + - compatible: Should be "fsl,imx25-tcq". > > + - reg: Memory range of the device. > > + - interrupts: Should be the interrupt number associated with this module within > > + the tscadc unit (<0>). > > + - interrupt-parent: Should be a phandle to the tscadc unit. > > + - fsl,wires: Should be '<4>' or '<5>' > > + > > +Optional properties: > > + - fsl,pen-debounce: Pen debounce time in nanoseconds. > > + - fsl,pen-threshold: Pen-down threshold for the touchscreen. > > + - fsl,settling-time: Settling time in nanoseconds. > > Don't we have standard properties for these? These are usually controller-specific so no. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:34666 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbbKQSVg (ORCPT ); Tue, 17 Nov 2015 13:21:36 -0500 Date: Tue, 17 Nov 2015 10:21:33 -0800 From: Dmitry Torokhov To: Rob Herring Cc: Markus Pargmann , Shawn Guo , Jonathan Cameron , Lee Jones , Denis Carikli , Eric =?iso-8859-1?Q?B=E9nard?= , Sascha Hauer , devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hartmut Knaack , Fabio Estevam Subject: Re: [PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller Message-ID: <20151117182133.GD29423@dtor-ws> References: <1447675269-8831-1-git-send-email-mpa@pengutronix.de> <1447675269-8831-4-git-send-email-mpa@pengutronix.de> <20151116141609.GA6167@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20151116141609.GA6167@rob-hp-laptop> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Mon, Nov 16, 2015 at 08:16:09AM -0600, Rob Herring wrote: > On Mon, Nov 16, 2015 at 01:01:04PM +0100, Markus Pargmann wrote: > > This is the touchscreen conversion queue binding documentation. It uses > > the shared imx25 ADC. > > > > Signed-off-by: Markus Pargmann > > --- > > > > Notes: > > Changes in v5: > > - Fix signed/unsigned comparison > > - Fix unused variable settling_time by putting it in the correct argument list > > - Use continous conversion queue with the repeat feature and a proper > > repeat-wait. Previously the touchscreen caused massive number of interrupts. > > > > .../bindings/input/touchscreen/fsl-mx25-tcq.txt | 29 ++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt b/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > new file mode 100644 > > index 000000000000..89ab47a3acc1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > @@ -0,0 +1,29 @@ > > +Freescale mx25 TS conversion queue module > > + > > +mx25 touchscreen conversion queue module which controls the ADC unit of the > > +mx25 for attached touchscreens. > > + > > +Required properties: > > + - compatible: Should be "fsl,imx25-tcq". > > + - reg: Memory range of the device. > > + - interrupts: Should be the interrupt number associated with this module within > > + the tscadc unit (<0>). > > + - interrupt-parent: Should be a phandle to the tscadc unit. > > + - fsl,wires: Should be '<4>' or '<5>' > > + > > +Optional properties: > > + - fsl,pen-debounce: Pen debounce time in nanoseconds. > > + - fsl,pen-threshold: Pen-down threshold for the touchscreen. > > + - fsl,settling-time: Settling time in nanoseconds. > > Don't we have standard properties for these? These are usually controller-specific so no. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Tue, 17 Nov 2015 10:21:33 -0800 Subject: [PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller In-Reply-To: <20151116141609.GA6167@rob-hp-laptop> References: <1447675269-8831-1-git-send-email-mpa@pengutronix.de> <1447675269-8831-4-git-send-email-mpa@pengutronix.de> <20151116141609.GA6167@rob-hp-laptop> Message-ID: <20151117182133.GD29423@dtor-ws> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 16, 2015 at 08:16:09AM -0600, Rob Herring wrote: > On Mon, Nov 16, 2015 at 01:01:04PM +0100, Markus Pargmann wrote: > > This is the touchscreen conversion queue binding documentation. It uses > > the shared imx25 ADC. > > > > Signed-off-by: Markus Pargmann > > --- > > > > Notes: > > Changes in v5: > > - Fix signed/unsigned comparison > > - Fix unused variable settling_time by putting it in the correct argument list > > - Use continous conversion queue with the repeat feature and a proper > > repeat-wait. Previously the touchscreen caused massive number of interrupts. > > > > .../bindings/input/touchscreen/fsl-mx25-tcq.txt | 29 ++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt b/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > new file mode 100644 > > index 000000000000..89ab47a3acc1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl-mx25-tcq.txt > > @@ -0,0 +1,29 @@ > > +Freescale mx25 TS conversion queue module > > + > > +mx25 touchscreen conversion queue module which controls the ADC unit of the > > +mx25 for attached touchscreens. > > + > > +Required properties: > > + - compatible: Should be "fsl,imx25-tcq". > > + - reg: Memory range of the device. > > + - interrupts: Should be the interrupt number associated with this module within > > + the tscadc unit (<0>). > > + - interrupt-parent: Should be a phandle to the tscadc unit. > > + - fsl,wires: Should be '<4>' or '<5>' > > + > > +Optional properties: > > + - fsl,pen-debounce: Pen debounce time in nanoseconds. > > + - fsl,pen-threshold: Pen-down threshold for the touchscreen. > > + - fsl,settling-time: Settling time in nanoseconds. > > Don't we have standard properties for these? These are usually controller-specific so no. Thanks. -- Dmitry