From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz4b8-00047P-1J for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:24:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz4b7-00041L-Co for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:24:38 -0500 Date: Wed, 18 Nov 2015 16:24:29 +0100 From: Kevin Wolf Message-ID: <20151118152429.GG4817@noname.str.redhat.com> References: <1447108773-6836-1-git-send-email-mreitz@redhat.com> <1447108773-6836-3-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447108773-6836-3-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Alberto Garcia , qemu-block@nongnu.org, John Snow , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > If block_job_create() fails, it should release its reference to the > job's BDS. Normally, this is done in the callback provided by the > caller, but that callback will not be invoked if the block job failed to > be created. > > Signed-off-by: Max Reitz > Reviewed-by: Alberto Garcia > Reviewed-by: Kevin Wolf Commit 18930ba3 already fixed this. Now adding another bdrv_unref() would be wrong, so I guess we have to simply drop the patch. NACK