From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756329AbbKRQzU (ORCPT ); Wed, 18 Nov 2015 11:55:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:54090 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbbKRQzQ (ORCPT ); Wed, 18 Nov 2015 11:55:16 -0500 Date: Wed, 18 Nov 2015 17:55:14 +0100 From: Petr Mladek To: Chris J Arges Cc: live-patching@vger.kernel.org, jpoimboe@redhat.com, sjenning@redhat.com, jikos@kernel.org, vojtech@suse.com, jeyu@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc Message-ID: <20151118165514.GO4431@pathway.suse.cz> References: <1447431804-18786-1-git-send-email-chris.j.arges@canonical.com> <1447693391-10065-1-git-send-email-chris.j.arges@canonical.com> <1447693391-10065-3-git-send-email-chris.j.arges@canonical.com> <20151118163707.GM4431@pathway.suse.cz> <564CA9BC.8020903@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564CA9BC.8020903@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2015-11-18 10:39:24, Chris J Arges wrote: > On 11/18/2015 10:37 AM, Petr Mladek wrote: > > On Mon 2015-11-16 11:03:06, Chris J Arges wrote: > >> In cases of duplicate symbols, sympos will be used to disambiguate instead > >> of val. By default sympos will be 0, and patching will only succeed if > >> the symbol is unique. Specifying a positive value will ensure that > >> occurrence of the symbol in kallsyms for the patched object will be used > >> for patching if it is valid. > >> > >> Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol > >> as they are no longer used. > >> > >> >From the klp_reloc structure remove val, as it can be refactored as a > > ^ > > Please, remove this extra '>'. I guess that you cut&pasted the > > comment from a mail reply ;-) > > > > Best Regards, > > Petr > > > > I think that '>' was added in a subsequent reply. My patch doesn't have > that, and I'm guessing checkpatch would have warned me about that as well. > : ) Heh, it seems that some mail delivery tool or mail client tries to be clever. I see the '>' in you original mail. But it is fine in the archive, see http://article.gmane.org/gmane.linux.kernel/2086364 http://marc.info/?l=linux-kernel&m=144769343212421 I am sorry for the noise. Best Regards, Petr