All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] gpt: command: Extend gpt command to support GPT table verification
Date: Thu, 19 Nov 2015 06:45:50 +0100	[thread overview]
Message-ID: <20151119064550.72c02b28@jawa> (raw)
In-Reply-To: <20151118234048.GE8060@bill-the-cat>

On Wed, 18 Nov 2015 18:40:48 -0500
Tom Rini <trini@konsulko.com> wrote:

> On Fri, Nov 13, 2015 at 07:42:12AM +0100, Lukasz Majewski wrote:
> 
> > This commit adds support for "gpt verify" command, which verifies
> > correctness of on-board stored GPT partition table.
> > As the optional parameter one can provide '$partitons' environment
> > variable to check if partition data (size, offset, name) is correct.
> > 
> > This command should be regarded as complementary one to "gpt
> > restore".
> > 
> > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> 
> Note you're using puts and printf both here, please just switch to
> printf.  But:
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 

I will fix this in v2. I also need to fix some issues with
"$partitions" parsing code.

Anyway, thanks for review.

Best regards,
?ukasz Majewski

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151119/0488d704/attachment.sig>

  reply	other threads:[~2015-11-19  5:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  6:42 [U-Boot] [PATCH 0/6] gpt: command: Add support for "gpt verify" command Lukasz Majewski
2015-11-13  6:42 ` [U-Boot] [PATCH 1/6] gpt: command: Remove duplicated check for empty partition description Lukasz Majewski
2015-11-18 23:38   ` Tom Rini
2015-11-13  6:42 ` [U-Boot] [PATCH 2/6] gpt: command: cosmetic: Replace printf with puts Lukasz Majewski
2015-11-18 23:37   ` Tom Rini
2015-11-19  5:43     ` Lukasz Majewski
2015-11-13  6:42 ` [U-Boot] [PATCH 3/6] gpt: doc: README: Update README entry for gpt verify extension Lukasz Majewski
2015-11-18 23:38   ` Tom Rini
2015-11-13  6:42 ` [U-Boot] [PATCH 4/6] gpt: doc: Update gpt command's help description Lukasz Majewski
2015-11-18 23:38   ` Tom Rini
2015-11-23 22:44   ` [U-Boot] [U-Boot, " Tom Rini
2015-11-13  6:42 ` [U-Boot] [PATCH 5/6] gpt: part: Definition and declaration of GPT verification functions Lukasz Majewski
2015-11-18 23:39   ` Tom Rini
2015-11-13  6:42 ` [U-Boot] [PATCH 6/6] gpt: command: Extend gpt command to support GPT table verification Lukasz Majewski
2015-11-18 23:40   ` Tom Rini
2015-11-19  5:45     ` Lukasz Majewski [this message]
2015-11-20  7:06 ` [U-Boot] [PATCH v2 0/5] gpt: command: Add support for "gpt verify" command Lukasz Majewski
2015-11-20  7:06   ` [U-Boot] [PATCH v2 1/5] gpt: command: Remove duplicated check for empty partition description Lukasz Majewski
2015-11-23 22:44     ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-11-20  7:06   ` [U-Boot] [PATCH v2 2/5] gpt: doc: README: Update README entry for gpt verify extension Lukasz Majewski
2015-11-23 22:44     ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-11-20  7:06   ` [U-Boot] [PATCH v2 4/5] gpt: part: Definition and declaration of GPT verification functions Lukasz Majewski
2015-11-20 11:19     ` Przemyslaw Marczak
2015-11-23 22:44     ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-11-24  9:56       ` Przemyslaw Marczak
2015-11-24 18:56         ` Tom Rini
2015-11-25  9:06           ` Przemyslaw Marczak
2015-11-20  7:06   ` [U-Boot] [PATCH v2 5/5] gpt: command: Extend gpt command to support GPT table verification Lukasz Majewski
2015-11-20 11:20     ` Przemyslaw Marczak
2015-11-23 22:44     ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-11-23 22:43   ` [U-Boot] [PATCH v2 0/5] gpt: command: Add support for "gpt verify" command Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151119064550.72c02b28@jawa \
    --to=l.majewski@majess.pl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.