From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 12/31] drm/i915: Fix PSR initialization. Date: Thu, 19 Nov 2015 10:34:50 +0100 Message-ID: <20151119093450.GQ20799@phenom.ffwll.local> References: <1446749423-4789-1-git-send-email-rodrigo.vivi@intel.com> <1446749423-4789-13-git-send-email-rodrigo.vivi@intel.com> <20151118101200.GJ20799@phenom.ffwll.local> <1447872025.15751.100.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86FE87A08A for ; Thu, 19 Nov 2015 01:34:54 -0800 (PST) Received: by wmvv187 with SMTP id v187so15900678wmv.1 for ; Thu, 19 Nov 2015 01:34:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <1447872025.15751.100.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMTgsIDIwMTUgYXQgMDY6Mzk6NDVQTSArMDAwMCwgVml2aSwgUm9kcmlnbyB3 cm90ZToKPiBPbiBXZWQsIDIwMTUtMTEtMTggYXQgMTE6MTIgKzAxMDAsIERhbmllbCBWZXR0ZXIg d3JvdGU6Cj4gPiBPbiBUaHUsIE5vdiAwNSwgMjAxNSBhdCAxMDo1MDowNEFNIC0wODAwLCBSb2Ry aWdvIFZpdmkgd3JvdGU6Cj4gPiA+IFBTUiBpcyBzdGlsbCBkaXNhYmxlZCBieSBkZWZhdWx0LCBi dXQgZXZlbiBwYXNzaW5nIAo+ID4gPiBpOTE1LmVuYWJsZV9wc3I9MQo+ID4gPiBhdCB0aGlzIHBv aW50IHdlIHdlcmVuJ3QgYWJsZSB0byBnZXQgUFNSIHdvcmtpbmcgYmVjYXVzZSB3aXRoCj4gPiA+ IGZhc3Rib290IGJ5IGRlZmF1bHQgaW4gcGxhY2Ugd2Ugd2VyZW4ndCBleGVjdXRpbmcgdGhlIHBh dGggdGhhdCAKPiA+ID4gZW5hYmxlcwo+ID4gPiBlbmNvZGVyIGFuZCBjb25zZXF1ZW50bHkgUFNS Lgo+ID4gPiAKPiA+ID4gTm93IHdpdGggcHNyX3JlYWR5IGluIHBsYWNlIGFuZCBQU1IgdXNpbmcg Y3J0YyBzaWduYXR1cmUgd2UgY2FuIAo+ID4gPiBtb3ZlCj4gPiA+IGl0cyBlbmFibGUvZGlzYWJs ZSBzZXF1ZW5jZXMgZnJvbSB0aGUgZW5jb2RlciBlbmFibGUgdG8gdGhlIHBvc3QKPiA+ID4gYXRv bWljIG1vZGVzZXQgZnVuY3Rpb25zLgo+ID4gPiAKPiA+ID4gaTkxNS5lbmFibGVfcHNyIHBhcmFt ZXRlciBpcyBzdGlsbCB1c2VkIHRvIGVuYWJsZS9kaXNhYmxlIHBzciAKPiA+ID4gZmVhdHVyZQo+ ID4gPiBvbiB0aGUgbmV4dCBwcmltYXJ5IHBsYW5lIHVwZGF0ZS4gU28gY3VycmVudCB0ZXN0IGNh c2VzIHRoYXQgcmVsaWVzCj4gPiA+IG9uIHRoaXMgZmxvdyBzdGlsbCB3b3Jrcy4KPiA+ID4gCj4g PiA+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4K PiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgICAgfCAg MiAtLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTUgKysr KysrKysrKysrKysrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAg fCAgNSAtLS0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwg IDIgKysKPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlv bnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kZGkuYyAKPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiBp bmRleCBiOGY4ZGVlLi4zNmRiOTcwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYwo+ID4gPiBAQCAtMjQwNCw3ICsyNDA0LDYgQEAgc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxl X2RkaShzdHJ1Y3QgCj4gPiA+IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIpCj4gPiA+ICAJ CQlpbnRlbF9kcF9zdG9wX2xpbmtfdHJhaW4oaW50ZWxfZHApOwo+ID4gPiAgCj4gPiA+ICAJCWlu dGVsX2VkcF9iYWNrbGlnaHRfb24oaW50ZWxfZHApOwo+ID4gPiAtCQlpbnRlbF9wc3JfZW5hYmxl KGludGVsX2NydGMpOwo+ID4gPiAgCQlpbnRlbF9lZHBfZHJyc19lbmFibGUoaW50ZWxfZHApOwo+ ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiBAQCAtMjQzMiw3ICsyNDMxLDYgQEAgc3RhdGljIHZvaWQg aW50ZWxfZGlzYWJsZV9kZGkoc3RydWN0IAo+ID4gPiBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNv ZGVyKQo+ID4gPiAgCQlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gCj4gPiA+IGVuY190b19p bnRlbF9kcChlbmNvZGVyKTsKPiA+ID4gIAo+ID4gPiAgCQlpbnRlbF9lZHBfZHJyc19kaXNhYmxl KGludGVsX2RwKTsKPiA+ID4gLQkJaW50ZWxfcHNyX2Rpc2FibGUoaW50ZWxfY3J0Yyk7Cj4gPiA+ ICAJCWludGVsX2VkcF9iYWNrbGlnaHRfb2ZmKGludGVsX2RwKTsKPiA+ID4gIAl9Cj4gPiA+ICB9 Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg Cj4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+IGluZGV4 IDg2OTkyOWQuLmY2N2UyZWUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiA+ID4gQEAgLTQ2ODcsNiArNDY4Nyw5IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bv c3RfcGxhbmVfdXBkYXRlKHN0cnVjdCAKPiA+ID4gaW50ZWxfY3J0YyAqY3J0YykKPiA+ID4gIAlp ZiAoYXRvbWljLT5lbmFibGVfaXBzKQo+ID4gPiAgCQlpbnRlbF9pcHNfZW5hYmxlKGNydGMpOwo+ ID4gPiAgCj4gPiA+ICsJaWYgKGF0b21pYy0+ZW5hYmxlX3BzcikKPiA+ID4gKwkJaW50ZWxfcHNy X2VuYWJsZShjcnRjKTsKPiA+IAo+ID4gV2hhdCB3ZSBuZWVkIGhlcmUgaXMgYSBwb3N0LW1vZGVz ZXQgZml4dXAgaG9vayBmb3IgCj4gPiBlbmNvZGVycy9jb25uZWN0b3JzLgo+ID4gVGhhdCB3b3Vs ZCBhdm9pZCB0aGUgbGF5ZXJpbmcgdmlvbGF0aW9uIG9mIGdvaW5nIHRocm91Z2ggYSBjcnRjIGFu ZCAKPiA+IHRoZW4KPiA+IGRvaW5nIHRoZSBjcnRjLT5lbmNvZGVyIGxvb2t1cCB5b3UgZG8gaW4g dGhlIHByZXZpb3VzIHBhdGNoLiBBbmQgd2UgCj4gPiBoYXZlCj4gPiBvdGhlciB1c2VzIGZvciB0 aGlzLCBlLmcuIG1pcGkgc2VsZiByZWZyZXNoLCBmaXhpbmcgdXAgaW5mb2ZyYW1lcyBhbmQgCj4g PiBhbGwKPiA+IHRob3NlIHRoaW5ncy4KPiAKPiBJIHNlZSB5b3VyIHBvaW50IGJ1dCBJJ20gbm90 IHN1cmUgaWYgSSB0b3RhbGx5IGdvdCB5b3VyIGlkZWEuCj4gCj4gU28gd291bGQgaXQgYmUgYSBn ZW5lcmljIGhvb2sgd2hlbiB3ZSBkZXRlY3QgZW5jb2Rlci9jb25uZWN0b3IgYmVpbmcKPiBlbmFi bGVkL2Rpc2FibGVkPwo+IAo+IGFuZCBob3cgdG8gZGV0ZXJtaW5lIHRoYXQ/IGNvdWxkIHlvdSBw bGVhc2UgZWxhYm9yYXRlIHlvdXIgaWRlYSBhIGJpdAo+IG1vcmU/CgoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwppbmRleCBjM2JjNmFiNzc1MDguLjQyN2RhYWM0ODBmNSAxMDA2NDQK LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCisrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwpAQCAtMTMyNzMsNiArMTMyNzMsMTEgQEAgc3Rh dGljIGludCBpbnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCiAJCQlt b2Rlc2V0X3B1dF9wb3dlcl9kb21haW5zKGRldl9wcml2LCBwdXRfZG9tYWlucyk7CiAKIAkJaW50 ZWxfcG9zdF9wbGFuZV91cGRhdGUoaW50ZWxfY3J0Yyk7CisKKwkJaWYgKG5lZWRzX21vZGVzZXQg fHwgdXBkYXRlX3BpcGUpIHsKKwkJCWZvcl9lYWNoX2VuY29kZXJfb25fY3J0YyhkZXYsIGNydGMs IGVuY29kZXIpCisJCQkJZW5jb2Rlci0+ZW5hYmxlX2ZpeHVwKGVuY29kZXIpOworCQl9CiAJfQog CiAJLyogRklYTUU6IGFkZCBzdWJwaXhlbCBvcmRlciAqLwoKCldpdGggdGhpcyBlbmFibGVfZml4 dXAgKG1heWJlIHdlIHNob3VsZCBjYWxsIGl0IHBvc3RfcGxhbmVfZW5hYmxlKSB3aWxsCndpbGwg Z2V0IGNhbGxlZCBib3RoIHdoZW4gd2UgZG8gYSBmdWxsIG1vZGVzZXQsIGJ1dCBhbHNvIHdoZW4g d2UganVzdCBkbyBhCmZhc3QgbW9kZXNldC9waXBlIHVwZGF0ZS4gVGhlbiB3ZSBjYW4gbW92ZSBl dmVyeXRoaW5nIHRoYXQgd2UncmUgY3VycmVudGx5CmRvaW5nIGluIC0+ZW5hYmxlIHdoaWNoIGFs c28gbXVzdCBiZSBkb25lIGZvciBmYXN0Ym9vdCBpbnRvCi0+cG9zdF9wbGFuZV9lbmFibGUsIGxp a2UgaW5mb2ZyYW1lcywgRFJSUywgcHNyIG9yIHdoYXRldmVyLgoKVGhlIG9ubHkgdHJpY2t5IHBh cnQgaXMgdGhhdCB0aGUgY29yZSB3b24ndCBkbyB0aGUgYm9vay1rZWVwaW5nIGZvciB1cwphbnlt b3JlLCBpLmUuIHdlIG5lZWQgdG8gY2hlY2sgb3Vyc2VsdmVzIGluIHRoaXMgbmV3IGhvb2sgd2hl dGhlciB3ZSBuZWVkCnRvIGRvIHRoZSBzZXR1cCBvciBub3QsIHNpbmNlIGlmIHVzZXJzcGFjZSBv bmx5IGNoYW5nZXMgdGhlIHNjYWxpbmcgYSBsb3QKd2UgbWlnaHQgZ2V0IGEgbG90IG9mIC0+cG9z dF9wbGFuZV9lbmFibGUgY2FsbHMgd2l0aG91dCBhbnkgLT5kaXNhYmxlCmNhbGxzIGluIGJldHdl ZW4uIFNvIHRoYXQncyBhbHNvIHdoZXJlIHlvdSBoYXZlIHRvIHB1dCB5b3VyIGNoZWNrczoKCmlu dGVsX2RwX3Bvc3RfcGxhbmVfZW5hYmxlKCkKewoJaWYgKCFwc3JfZW5hYmxlZCkKCQllbmFibGVf cHNyKCk7CgoJaWYgKCFEUlJTX29uKQoJCWVuYWJsZV9kcnJzKCk7CgoJLyogbWF5YmUgaW4gdGhl IGZ1dHVyZSAqLwoJaWYgKCFhdWRpb19lbmFibGVkKQoJCWVuYWJsZV9hdWRpbygpOwp9CgoKaW50 ZWxfaGRtaV9wb3N0X3BsYW5lX2VuYWJsZSgpCnsKCS8qIGlmeHVwIGluZm9mcmFtZXMgaWYgdGhl eSdyZSBjcmFwIGZyb20gdGhlIGJpb3MgKi8KfQoKQ2hlZXJzLCBEYW5pZWwKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==